Skip to content

Conversation

@marekmatej
Copy link

@marekmatej marekmatej commented Jun 11, 2024

Update the hal_espressif to include latest esptool version.
Improve support for new SoCs as such as ESP32-C6.
Fix bugs related to segment alignment.

Fix issue related in PR #73437

@zephyrbot zephyrbot added the size: XS A PR changing only a single line of code label Jun 11, 2024
@zephyrbot
Copy link

zephyrbot commented Jun 11, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_espressif zephyrproject-rtos/hal_espressif@5191505 zephyrproject-rtos/hal_espressif@0690c03 (zephyr) zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

Copy link
Contributor

@str4t0m str4t0m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use the commit sha of the unmerged hal PR. Use pull/208/head until it's merged.

@sylvioalves sylvioalves force-pushed the feature/hal_espresif_update branch from b5e03f7 to 364d3dc Compare June 12, 2024 03:04
Update the hal_espressif to include latest esptool version.
Improve support for new SoCs as such as ESP32-C6.
Fix bugs related to segment alignment.

Signed-off-by: Marek Matej <[email protected]>
@sylvioalves sylvioalves force-pushed the feature/hal_espresif_update branch from 364d3dc to d6863f0 Compare June 12, 2024 03:06
@sylvioalves sylvioalves requested a review from nashif June 12, 2024 03:07
@str4t0m str4t0m dismissed their stale review June 12, 2024 04:34

HAL PR was merged and reference updated.

@marekmatej
Copy link
Author

Please don't use the commit sha of the unmerged hal PR. Use pull/208/head until it's merged.

hi @str4t0m thanks for the comment. I used ref as related PR was on the verge of merging. Can you revisit this, please?

@str4t0m
Copy link
Contributor

str4t0m commented Jun 12, 2024

My change request has been addressed and no longer blocks the PR.
With any second approval it may be merged.
I would have to test and have a closer look at the changes before giving an approval which I won't be able to do before evening.

@nashif nashif merged commit 0153b34 into zephyrproject-rtos:main Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manifest manifest-hal_espressif size: XS A PR changing only a single line of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants