Add realtek rts5912 soc #75267

JasonLin-RealTek · 2024-07-01T13:02:53Z

This PR adds support for the RTS5912 EC Chip from Realtek.

The initial support for the board includes TIMER, GPIO, CLOCK_CONTROL, PINCTRL.

please help us review the pull request.

Thanks!

github-actions · 2024-07-01T13:03:34Z

Hello @JasonLin-RealTek, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

gmarull

please, organize commit content properly, it seems that first commit contains e.g. pinctrl stuff which should not be there.

nordicjm · 2024-07-01T13:30:20Z

boards/realtek/rts5912_evb/Kconfig.defconfig

Suggested change

config BOARD

default "rts5912_evb"

this is hwmv1

nordicjm · 2024-07-01T13:30:33Z

boards/realtek/rts5912_evb/Kconfig.rts5912_evb

Suggested change

bool "Realtek RTS5912 Evaluation Board"

nordicjm · 2024-07-01T13:30:57Z

boards/realtek/rts5912_evb/doc/rts5912evb.png

convert to webp, then put it through https://tinypng.com/

nordicjm · 2024-07-01T13:31:25Z

boards/realtek/rts5912_evb/rts5912_evb.dts

non-blocking comment: should there be flash partitions here?

unaddressed

power states must not be at board level

We have put those power state to rts5912.dtsi.

nordicjm · 2024-07-01T13:31:40Z

boards/realtek/rts5912_evb/rts5912_evb_defconfig

Suggested change

# CONSOLE

# Console

nordicjm · 2024-07-01T13:37:04Z

soc/realtek/ec/Kconfig.defconfig

Suggested change

if SOC_FAMILY_REALTEK_EC

rsource "*/Kconfig.defconfig.series"

endif # SOC_FAMILY_REALTEK_EC

if SOC_FAMILY_REALTEK_EC

rsource "*/Kconfig.defconfig.series"

endif # SOC_FAMILY_REALTEK_EC

nordicjm · 2024-07-01T13:37:12Z

soc/realtek/ec/Kconfig.soc

add newline

soc/realtek/ec/rts5912/Kconfig

nordicjm · 2024-07-01T13:37:54Z

soc/realtek/ec/rts5912/Kconfig

Suggested change

select SOC_FAMILY_REALTEK_EC

nordicjm · 2024-07-01T13:39:41Z

soc/realtek/ec/rts5912/Kconfig.soc

non-blocking comment: do you really need a soc series when the soc and soc series name as the same? Is this really a series?

There may be series and plenty of SoCs with different names in the future.

In order to maintain the consistency of the folder structure, we will use the same name for the series and SoCs for now.

JasonLin-RealTek · 2024-07-04T02:39:12Z

please, organize commit content properly, it seems that first commit contains e.g. pinctrl stuff which should not be there.

We followed the suggestions to fix the code and passed the twister testing.
Are there any further suggestions? Could you please approve the PR?

gmarull

I can't see any changes regarding my previous request

JasonLin-RealTek · 2024-07-05T11:11:20Z

I can't see any changes regarding my previous request

We misunderstood the request and moved the [pinctrl+register] files to their own commit.
Now we have committed the device tree file into a single commit.
Is that correct?

nordicjm · 2024-07-08T08:55:06Z

soc/realtek/ec/Kconfig

Suggested change

bool "The output binary with RTS5912 image header"

bool "Add RTS5912 image header to output binary"

nordicjm · 2024-07-08T08:55:15Z

soc/realtek/ec/Kconfig

nordicjm · 2024-07-08T08:56:45Z

soc/realtek/ec/Kconfig

But they should come from dts, not Kconfig

nordicjm · 2024-07-08T08:57:05Z

soc/realtek/ec/Kconfig

Suggested change

#source "soc/realtek/*/Kconfig.soc"

rettichschnidi

Very superficial review, but all my nits got fixed -> approved

fabiobaltieri · 2025-01-07T18:16:05Z

@gmarull could you take a look?

gmarull · 2025-01-08T09:08:13Z

drivers/clock_control/clock_control_rts5912_sccon.c

this should be captured in DT, see other examples by inspecting clocks {} node.

We added the clocks {} node and captured these in DT, thanks.

gmarull · 2025-01-08T09:09:48Z

soc/realtek/ec/rts5912/soc.c

We fixed it, thanks.

gmarull · 2025-01-08T09:10:12Z

soc/realtek/ec/rts5912/soc.c

local header, so #include "debug_swj.h"?

We fixed it, thanks.

gmarull · 2025-01-08T09:10:35Z

soc/realtek/ec/rts5912/soc.c

LOG_MODULE_REGISTER(soc, CONFIG_SOC_LOG_LEVEL);

We replaced LOG_MODULE_REGISTER(soc); with LOG_MODULE_REGISTER(soc, CONFIG_SOC_LOG_LEVEL);, thanks.

gmarull · 2025-01-08T09:11:41Z

include/zephyr/dt-bindings/gpio/realtek-gpio.h

1P8 -> 1V8 ?

We modified these relevant macros, thanks.

Add support for Realtek RTS5912 embedded controller (EC). Signed-off-by: Lin Yu-Cheng <[email protected]>

Add Realtek RTS5912 chip and driver device tree files. Signed-off-by: Lin Yu-Cheng <[email protected]>

Add clock controller driver for Realtek RTS5912. Signed-off-by: Lin Yu-Cheng <[email protected]>

Add pinctrl driver for Realtek RTS5912. Signed-off-by: Lin Yu-Cheng <[email protected]>

Add swj driver for Realtek RTS5912. Signed-off-by: Lin Yu-Cheng <[email protected]>

Add timer driver for Realtek RTS5912. Signed-off-by: Lin Yu-Cheng <[email protected]>

Add gpio driver for Realtek RTS5912. Signed-off-by: Lin Yu-Cheng <[email protected]>

Add UART driver for Realtek RTS5912. Signed-off-by: Lin Yu-Cheng <[email protected]>

Add support for Realtek rts5912_evb board Signed-off-by: Lin Yu-Cheng <[email protected]>

This commit adds api and driver of Realtek EC to maintainers.yml Signed-off-by: Lin Yu-Cheng <[email protected]>

github-actions · 2025-01-10T10:58:42Z

Hi @JasonLin-RealTek!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

zephyrbot added area: UART Universal Asynchronous Receiver-Transmitter area: Timer Timer area: Pinctrl area: GPIO area: Devicetree Binding PR modifies or adds a Device Tree binding area: Clock Control labels Jul 1, 2024

zephyrbot requested review from andyross, dcpleung, decsny, galak, gmarull, henrikbrixandersen, mnkp, nordic-krch and teburd July 1, 2024 13:03

zephyrbot assigned nordic-krch Jul 1, 2024

gmarull requested changes Jul 1, 2024

View reviewed changes

nordicjm requested changes Jul 1, 2024

View reviewed changes

JasonLin-RealTek force-pushed the add_realtek_rts5912_soc branch 2 times, most recently from e16ff4a to 7a10790 Compare July 3, 2024 11:08

JasonLin-RealTek requested review from gmarull and nordicjm July 5, 2024 03:10

gmarull requested changes Jul 5, 2024

View reviewed changes

JasonLin-RealTek force-pushed the add_realtek_rts5912_soc branch from 7a10790 to 7b8a3da Compare July 5, 2024 10:51

JasonLin-RealTek requested a review from gmarull July 8, 2024 02:15

nordicjm reviewed Jul 8, 2024

View reviewed changes

JasonLin-RealTek force-pushed the add_realtek_rts5912_soc branch from 7b8a3da to 2a3274a Compare July 8, 2024 11:37

keith-zephyr previously approved these changes Jan 7, 2025

View reviewed changes

keith-zephyr requested review from gmarull and rettichschnidi January 7, 2025 16:43

rettichschnidi previously approved these changes Jan 7, 2025

View reviewed changes

gmarull reviewed Jan 8, 2025

View reviewed changes

JasonLin-RealTek added 10 commits January 10, 2025 13:56

soc: realrek: ec: Add Realtek RTS5912 SoC

b1d100f

Add support for Realtek RTS5912 embedded controller (EC). Signed-off-by: Lin Yu-Cheng <[email protected]>

dts: realtek: Add RTS5912 device tree files

ac0c7ec

Add Realtek RTS5912 chip and driver device tree files. Signed-off-by: Lin Yu-Cheng <[email protected]>

driver: clock_control: Add clock controller initial version of RTS5912.

9df72bf

Add clock controller driver for Realtek RTS5912. Signed-off-by: Lin Yu-Cheng <[email protected]>

driver: pinctrl: Add pinctrl initial version of RTS5912.

8657bf7

Add pinctrl driver for Realtek RTS5912. Signed-off-by: Lin Yu-Cheng <[email protected]>

soc: realrek: ec: Add debug_swj initial version of RTS5912.

fed0b54

Add swj driver for Realtek RTS5912. Signed-off-by: Lin Yu-Cheng <[email protected]>

driver: timer: Add timer driver initial version of RTS5912.

bdf24fa

Add timer driver for Realtek RTS5912. Signed-off-by: Lin Yu-Cheng <[email protected]>

driver: gpio: Add gpio driver initial version of RTS5912.

10dc1cb

Add gpio driver for Realtek RTS5912. Signed-off-by: Lin Yu-Cheng <[email protected]>

driver: serial: Add UART driver initial version of RTS5912.

46b6d8c

Add UART driver for Realtek RTS5912. Signed-off-by: Lin Yu-Cheng <[email protected]>

boards: realtek: Add rts5912_evb board

04d085f

Add support for Realtek rts5912_evb board Signed-off-by: Lin Yu-Cheng <[email protected]>

MAINTAINERS: add maintainer for Realtek EC api and driver

135439e

This commit adds api and driver of Realtek EC to maintainers.yml Signed-off-by: Lin Yu-Cheng <[email protected]>

JasonLin-RealTek dismissed stale reviews from rettichschnidi, keith-zephyr, and fabiobaltieri via 135439e January 10, 2025 07:00

JasonLin-RealTek force-pushed the add_realtek_rts5912_soc branch from 3c411e6 to 135439e Compare January 10, 2025 07:00

gmarull approved these changes Jan 10, 2025

View reviewed changes

fabiobaltieri approved these changes Jan 10, 2025

View reviewed changes

bjarki-andreasen approved these changes Jan 10, 2025

View reviewed changes

kartben merged commit a4d0591 into zephyrproject-rtos:main Jan 10, 2025
25 checks passed

fabiobaltieri mentioned this pull request Feb 26, 2025

Collaborator nomination for JasonLin-RealTek #86380

Closed

-if SOC_FAMILY_REALTEK_EC
-rsource "*/Kconfig.defconfig.series"
-endif # SOC_FAMILY_REALTEK_EC
+if SOC_FAMILY_REALTEK_EC
+rsource "*/Kconfig.defconfig.series"
+endif # SOC_FAMILY_REALTEK_EC

	bool "The output binary with RTS5912 image header"
	bool "Add RTS5912 image header to output binary"

Add realtek rts5912 soc #75267

Add realtek rts5912 soc #75267

Uh oh!

Conversation

JasonLin-RealTek commented Jul 1, 2024

Uh oh!

github-actions bot commented Jul 1, 2024

Uh oh!

gmarull left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JasonLin-RealTek commented Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gmarull left a comment

Choose a reason for hiding this comment

Uh oh!

JasonLin-RealTek commented Jul 5, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rettichschnidi left a comment

Choose a reason for hiding this comment

Uh oh!

fabiobaltieri commented Jan 7, 2025

Uh oh!

JasonLin-RealTek commented Jul 4, 2024 •

edited

Loading

gmarull Jan 8, 2025 •

edited

Loading

gmarull Jan 8, 2025 •

edited

Loading