Skip to content

Conversation

@ozersa
Copy link
Contributor

@ozersa ozersa commented Jul 9, 2024

SPI driver implemented and merged onto main by #73496
It just enabled for MAX32690 by above PR..
Then new MAX32 MCUs that listed below merged into upstream/main. This PR enabled SPI for them.

@ttmut @hfakkiz @mertekren fyi.

DMA related addition is going to be pushed by a dedicated PR.

MaureenHelm
MaureenHelm previously approved these changes Jul 9, 2024
@ozersa
Copy link
Contributor Author

ozersa commented Jul 29, 2024

Conflicts are fixed, and rebased onto main.

MaureenHelm
MaureenHelm previously approved these changes Jul 29, 2024
@ozersa
Copy link
Contributor Author

ozersa commented Aug 2, 2024

Rebased to fix conflicts.

Copy link
Member

@MaureenHelm MaureenHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's follow #76601 and do the same for SPI

@ozersa ozersa force-pushed the add-MAX32xxx-SPI branch from 7cb8135 to 1c82318 Compare August 5, 2024 07:51
@ozersa
Copy link
Contributor Author

ozersa commented Aug 5, 2024

Let's follow #76601 and do the same for SPI

Sure, done. thanks.

Copy link
Member

@MaureenHelm MaureenHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests: i2c: i2c_target_api: Remove duplicate properties

SPI pins are defined in board.dts file to simplify usage
so that no need to redefine it in overlay files

Signed-off-by: Sadik Ozer <[email protected]>

The first line in the commit message has a copy/paste error, need to replace i2c with spi.

@ozersa ozersa force-pushed the add-MAX32xxx-SPI branch from 1c82318 to 9a3f955 Compare August 5, 2024 12:48
@ozersa
Copy link
Contributor Author

ozersa commented Aug 5, 2024

tests: i2c: i2c_target_api: Remove duplicate properties

SPI pins are defined in board.dts file to simplify usage
so that no need to redefine it in overlay files

Signed-off-by: Sadik Ozer <[email protected]>

The first line in the commit message has a copy/paste error, need to replace i2c with spi.

Fixed.

MaureenHelm
MaureenHelm previously approved these changes Aug 5, 2024
ubieda
ubieda previously approved these changes Aug 5, 2024
@ozersa ozersa dismissed stale reviews from ubieda and MaureenHelm via 95838f1 August 6, 2024 08:38
@ozersa ozersa force-pushed the add-MAX32xxx-SPI branch from 9a3f955 to 95838f1 Compare August 6, 2024 08:38
@zephyrbot zephyrbot requested a review from ttmut August 14, 2024 05:12
@ozersa
Copy link
Contributor Author

ozersa commented Aug 14, 2024

Needs rebase

Done, thanks.

ttmut and others added 21 commits August 14, 2024 09:51
Add MAX32655FTHR and MAX32655EVKIT board configuration for SPI loopback
test. Supports interrupt and asynchronous transfers as well as 16-bit
frames.

Co-Authored-By: Sadik Ozer <[email protected]>
Signed-off-by: Tahsin Mutlugun <[email protected]>
Add SPI nodes to MAX32670 dtsi file and add binding

Signed-off-by: Mert Ekren <[email protected]>
Add SPI into 'index.rst' and '.yaml' files.

Signed-off-by: Mert Ekren <[email protected]>
Enable SPI test for MAX32670EVKIT.

Signed-off-by: Mert Ekren <[email protected]>
Add SPI instances of MAX32672 to dtsi file.

Signed-off-by: Furkan Akkiz <[email protected]>
Add SPI into 'index.rst' and '.yaml' file of MAX32672 boards.

Signed-off-by: Furkan Akkiz <[email protected]>
Enable SPI test for MAX32672 boards.

Signed-off-by: Furkan Akkiz <[email protected]>
This commit adds MAX32680 SPI instances in dtsi file.

Signed-off-by: Tahsin Mutlugun <[email protected]>
Add SPI in supported driver list.

Signed-off-by: Tahsin Mutlugun <[email protected]>
Enable SPI test for MAX32680EVKIT board.

Signed-off-by: Tahsin Mutlugun <[email protected]>
Add SPI nodes to MAX32675 dtsi file and add binding

Signed-off-by: Mert Ekren <[email protected]>
Add SPI into 'index.rst' and '.yaml' files.

Signed-off-by: Mert Ekren <[email protected]>
Enable SPI test for MAX32675EVKIT.

Signed-off-by: Mert Ekren <[email protected]>
This commits add MAX32666 SPI instances in dts file

Signed-off-by: Sadik Ozer <[email protected]>
Add SPI in supported driver list

Signed-off-by: Sadik Ozer <[email protected]>
Enable SPI test for MAX32666FTHR board

Signed-off-by: Sadik Ozer <[email protected]>
Add SPI instances of MAX32662 to dtsi file.

Signed-off-by: Furkan Akkiz <[email protected]>
Add SPI into 'index.rst' and '.yaml' file of MAX32662EVKIT.

Signed-off-by: Furkan Akkiz <[email protected]>
Enable SPI test for MAX32662EVKIT.
SRAM size increased to get enough space for SPI test image

Co-Authored-By: Sadik Ozer <[email protected]>
Signed-off-by: Furkan Akkiz <[email protected]>
Define SPI pins to simplify SPI usage

Signed-off-by: Sadik Ozer <[email protected]>
SPI pins are defined in board.dts file to simplify usage
so that no need to redefine it in overlay files

Signed-off-by: Sadik Ozer <[email protected]>
@ozersa
Copy link
Contributor Author

ozersa commented Aug 14, 2024

DMA related addition removed, it will be pushed as separate PR.

@nashif nashif merged commit 568abf1 into zephyrproject-rtos:main Aug 14, 2024
@MaureenHelm MaureenHelm deleted the add-MAX32xxx-SPI branch August 14, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: SPI SPI bus platform: ADI Analog Devices, Inc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants