arc: nsim: vpx5: fix SoC config issue which leads to cmake error #75896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nashif
previously approved these changes
Jul 15, 2024
abrodkin
previously approved these changes
Jul 16, 2024
nordicjm
requested changes
Jul 16, 2024
Contributor
nordicjm
left a comment
nordicjm
left a comment
There was a problem hiding this comment.
Invalid, there is no soc series nsim_vpx5 in soc.yml
After recent nsim SoCs & boards reorganization the SOC_SERIES_* config is missing for vpx5 SoC which leads to cmake errors when building against nsim/nsim_vpx5 configuration. Fix that and align soc series name in soc.yml Signed-off-by: Evgeniy Paltsev <[email protected]> Signed-off-by: Eugeniy Paltsev <[email protected]>
evgeniy-paltsev
force-pushed
the
ep-nsim-vpx5-fix-config-v0
branch
from
269e75c to
5e1cd12
Compare
Contributor
Author
Thanks @nordicjm , good catch. I've aligned soc series name in soc.yml as well. |
abrodkin
approved these changes
Jul 16, 2024
nordicjm
approved these changes
Jul 17, 2024
nashif
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After recent nsim SoCs & boards reorganization the
SOC_SERIES_*config is missing for vpx5 SoC which leads to cmake errors when building against nsim/nsim_vpx5 configuration.Fixes: #72862
Fixes: #75898