- 
                Notifications
    
You must be signed in to change notification settings  - Fork 8.2k
 
drivers: dac: add max22017 support #76017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           Hello @granquet, and thank you very much for your first pull request to the Zephyr project!  | 
    
339249e    to
    8aab635      
    Compare
  
    8aab635    to
    e0df28d      
    Compare
  
    e0df28d    to
    9830e0d      
    Compare
  
    9830e0d    to
    4212a70      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @granquet for your PR and sorry for the late response. It got lost in my notifications for some reason.
As far as I can see, the DAC, ADC and GPIO features of this device are independent of each other. Can you please split out the GPIO driver from this PR and create a dedicated PR for it? This will help with reviews, as the GPIO and DAC drivers are maintained by different persons.
I will do a thorough review once the GPIO sections are taken out.
4212a70    to
    e7d8bc7      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add a node with this compatible to tests/drivers/build_all/dac/app.overlay
88663dd    to
    4f674c2      
    Compare
  
    | 
           @granquet , we are only merging bug fixes and documentation updates for the 4.0 release. I am changing the milestone to 4.1  | 
    
| 
           @granquet this would need to be rebased on main as it has merge conflicts  | 
    
b1ef23b    to
    aac30ed      
    Compare
  
    
          
 Thx for notifying me :)  | 
    
          
 Np :) you also have "interesting" commits in this PR that look like they don't want to be there :)  | 
    
982be6f    to
    8d03ec1      
    Compare
  
    b1b7de6    to
    5c5a616      
    Compare
  
    The MAX22017 DAC provides two 16 Channel Analog outputs and 6 GPIOs. Signed-off-by: Guillaume Ranquet <[email protected]>
The MAX22017 is a two-channel industrial-grade software-configurable analog output device that can be used in either voltage or current output mode. Signed-off-by: Guillaume Ranquet <[email protected]>
MAX22017 is a DAC with support for 6 GPIOs Signed-off-by: Guillaume Ranquet <[email protected]>
5c5a616    to
    6a8713f      
    Compare
  
    | 
           Hi @granquet! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁  | 
    
This series add support for the MAX22017 DAC.
The MAX22017 is a two-channel industrial-grade software-configurable analog output device that can be used in either voltage or current output mode.
The DAC also has support for six configurable GPIO.