Skip to content

Support Renesas RA4 devices #76081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 27, 2024
Merged

Support Renesas RA4 devices #76081

merged 9 commits into from
Aug 27, 2024

Conversation

@duynguyenxa
Copy link
Member

@duynguyenxa duynguyenxa commented Jul 19, 2024 •
edited
Loading

This PR target to support SoC and Board support as below:
EK-RA4M2
EK-RA4M3
EK-RA4E1
EK-RA4E2

Module:
SCI UART

@zephyrbot
Copy link

zephyrbot commented Jul 19, 2024 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_renesas DNM This PR should not be merged (Do Not Merge) labels Jul 19, 2024
@iandmorris iandmorris mentioned this pull request Jul 23, 2024
Closed
@ydamigos ydamigos added the platform: Renesas RA Renesas Electronics Corporation, RA label Jul 26, 2024
ydamigos
ydamigos requested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@ydamigos ydamigos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update maintainers yaml to add the board.

@ydamigos ydamigos requested review from soburi and thaoluonguw August 1, 2024 07:38
@soburi
Copy link
Member

soburi commented Aug 2, 2024 •
edited
Loading

@duynguyenxa

The CMSIS header has a difference with v5.3.0.
If it is not required at this time, I think it is good to use the v5.3.0 version.
And this PR has the same modification for the SCI driver for SCI-B in zephyrproject-rtos/hal_renesas#24 (comment).

Let's record this as well.

And this PR has no other problems.

I commented in the wrong place. Move to zephyrproject-rtos/hal_renesas#26 (comment)

This was referenced Aug 2, 2024
Merged
Merged
@duynguyenxa duynguyenxa mentioned this pull request Aug 8, 2024
Closed
nordicjm
nordicjm requested changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the same issues as raised in the other PR

ydamigos
ydamigos requested changes Aug 12, 2024
View reviewed changes
@zephyrbot zephyrbot removed manifest manifest-hal_renesas DNM This PR should not be merged (Do Not Merge) labels Aug 15, 2024
@duynguyenxa duynguyenxa marked this pull request as ready for review August 19, 2024 11:37
@zephyrbot zephyrbot requested a review from dcpleung August 19, 2024 11:37
@ydamigos ydamigos requested review from nordicjm and ydamigos August 19, 2024 11:40
ydamigos
ydamigos requested changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@ydamigos ydamigos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the PR also add support for RA6? If not, please clean it up.

@henrikbrixandersen henrikbrixandersen removed their request for review August 20, 2024 08:01
nordicjm
nordicjm requested changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only looked at 2 commits, apply these comments to every commit in this PR

soc/renesas/ra/ra4e2/Kconfig Outdated
Comment on lines 15 to 16
Copy link
Contributor

@nordicjm nordicjm Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
help
Enable support for Renesas RA4E2 MCU series

boards/renesas/ek_ra4e2/doc/ek-ra4e2-board.jpg Outdated
Copy link
Contributor

@nordicjm nordicjm Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convert to webp then put through https://tinypng.com/

boards/renesas/ek_ra4e2/doc/index.rst Outdated
Copy link
Contributor

@nordicjm nordicjm Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

board target

boards/renesas/ek_ra4e2/doc/ra4e2-block-diagram.jpg Outdated
Copy link
Contributor

@nordicjm nordicjm Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as prior

@quytranpzz @thenguyenyf
soc: renesas: Add initial support for RA4E2 soc
601a0dd 
Initial commit to support Renesas RA4E2 SoC

Signed-off-by: Quy Tran <[email protected]>
@quytranpzz @thenguyenyf
boards: renesas: Add initial support for EK-RA4E2 board
8908925 
Initial commit to support Renesas EK-RA4E2 board

Signed-off-by: Quy Tran <[email protected]>
Signed-off-by: Duy Phuong Hoang. Nguyen <[email protected]>
@quytranpzz @thenguyenyf
soc: renesas: Add initial support for RA4M2 SoC
4568561 
Initial commit to support Renesas RA4M2 Soc

Signed-off-by: Quy Tran <[email protected]>
@quytranpzz @thenguyenyf
boards: renesas: Add initial support for EK-RA4M2
5250af1 
Initial commit to support Renesas EK-RA4M2 board

Signed-off-by: Quy Tran <[email protected]>
Signed-off-by: Duy Phuong Hoang. Nguyen <[email protected]>
@quytranpzz @thenguyenyf
soc: renesas: Add initial support for RA4M3 SOC
cf0948f 
Initial commit to support Renesas RA4M3 SOC

Signed-off-by: Quy Tran <[email protected]>
@quytranpzz @thenguyenyf
boards: renesas: Add initial support for EK-RA4M3 board
91a9737 
Initial commit to support Renesas EK-RA4M3 board

Signed-off-by: Quy Tran <[email protected]>
Signed-off-by: Duy Phuong Hoang. Nguyen <[email protected]>
@quytranpzz @thenguyenyf
soc: renesas: Add initial support for RA4W1 SOC
893d699 
Initial commit to support Renesas RA4W1 SOC

Signed-off-by: Quy Tran <[email protected]>
@quytranpzz @thenguyenyf
boards: renesas: Add initial support for EK-RA4W1 board
8688c4b 
Initial commit to support Renesas EK-RA4W1 board

Signed-off-by: Quy Tran <[email protected]>
Signed-off-by: Duy Phuong Hoang. Nguyen <[email protected]>
@quytranpzz @thenguyenyf
dts: bindings: clock: Change clock control binding for Renesas RA
62de542 
Background of this modification is to make clock control
driver code provided by Renesas vendor to support for Renesas MCU
on Zephyr.

Signed-off-by: Quy Tran <[email protected]>
@thenguyenyf
Copy link
Contributor

thenguyenyf commented Aug 22, 2024

Hi @ydamigos , @nordicjm. I have updated as your request. Would you please review it?

ydamigos
ydamigos requested changes Aug 22, 2024
View reviewed changes
@ydamigos ydamigos self-requested a review August 22, 2024 10:54
@ydamigos ydamigos requested a review from nordicjm August 27, 2024 10:51
@KhiemNguyenT
Copy link

KhiemNguyenT commented Aug 27, 2024

@soburi , please take a look, esp. the common stuffs with the RA4M1 board support from you.

@KhiemNguyenT KhiemNguyenT added this to the v4.0.0 milestone Aug 27, 2024
@nashif nashif merged commit d1d42ec into zephyrproject-rtos:main Aug 27, 2024
@duynguyenxa duynguyenxa mentioned this pull request Aug 28, 2024
Merged
@thenguyenyf thenguyenyf deleted the support-ra4-PR2.0 branch November 7, 2024 06:13
@quytranpzz quytranpzz mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ydamigos ydamigos ydamigos approved these changes

@KhiemNguyenT KhiemNguyenT KhiemNguyenT approved these changes

@nordicjm nordicjm nordicjm approved these changes

@soburi soburi Awaiting requested review from soburi

@thaoluonguw thaoluonguw Awaiting requested review from thaoluonguw

@dcpleung dcpleung Awaiting requested review from dcpleung

@gmarull gmarull Awaiting requested review from gmarull

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@mnkp mnkp Awaiting requested review from mnkp

@nashif nashif Awaiting requested review from nashif

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

@stephanosio stephanosio Awaiting requested review from stephanosio

Assignees

@KhiemNguyenT KhiemNguyenT

Labels

area: Clock Control area: GPIO area: Pinctrl area: Process area: UART Universal Asynchronous Receiver-Transmitter platform: Renesas RA Renesas Electronics Corporation, RA

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

9 participants

@duynguyenxa @zephyrbot @soburi @thenguyenyf @KhiemNguyenT @ydamigos @nordicjm @nashif @quytranpzz