west: blobs: verify fetched blobs after downloading #76186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
57300,
carlescufi,
jeremybettis,
mbolivar-ampere,
nashif,
nordicjm,
swinslow and
tejlmand
pdgendt
previously approved these changes
Jul 23, 2024
57300
previously approved these changes
Jul 23, 2024
dottspina
force-pushed
the
pr-verify-fetched-blobs
branch
from
4f2633c to
f27f80c
Compare
Replace blob status literals with the corresponding constants defined in zephyr_module. Signed-off-by: Christophe Dufaza <[email protected]>
Running 'west blobs fetch' does not verify the digest of downloaded files: 1. if the checksum of the previously downloaded file does match that in the blob metadata (status BLOB_PRESENT), do nothing 2. if the checksum of the previously downloaded file does not match that in the blob metadata (status BLOB_OUTDATED), download the "up to date" file 3. if the blob has not yet been downloaded (status BLOB_NOT_PRESENT), download it None of the 2) and 3) code paths will verify that the checksum of the file just downloaded actually matches the digest in the blob's metadata. In the event that the metadata of a module is incorrect, then the user will not notice anything, and may rely on an unexpected binary, e.g. a static library for a different architecture. According to the Binary Blobs documentation [1], the expected behavior is to check the blob digest after downloading. [1] Fetching blobs, Zephyr 3.6.0 (still applies to Zephyr 3.7.0rc3) docs.zephyrproject.org/3.6.0/contribute/bin_blobs.html#fetching-blobs Signed-off-by: Christophe Dufaza <[email protected]>
dottspina
force-pushed
the
pr-verify-fetched-blobs
branch
from
f27f80c to
771bcde
Compare
pdgendt
approved these changes
Jul 23, 2024
sylvioalves
approved these changes
Jul 25, 2024
tejlmand
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
Running
west blobs fetchdoes not verify the digest of downloaded files.Fixes #76185
Proposed change
Call
zephyr_module.get_blob_status()(again) after downloading, and warn the user if the blob status isBLOB_OUTDATED(digests don't match).Note: The proposed error message is intended to not be scary, and assumes incorrect metadata (URL or digest) rather than a compromised download:
Thanks.