lis2dux12: fix mode argument when setting odr #76323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avisconti
added
area: Drivers
area: Sensors
avisconti
added
bug
zephyrbot
requested review from
erwango,
jeppenodgaard,
jfischer-no,
kartben,
nashif,
tristan-google and
yperess
ubieda
approved these changes
Jul 26, 2024
MaureenHelm
approved these changes
Jul 26, 2024
ubieda
approved these changes
Jul 29, 2024
In lis2dux12_set_odr(), the call to stmemsc module lis2dux12_mode_set() API is done with the .fs field left uninitialized, so setting the underlying device regs in an unproper way. Suggested-by: Luis Ubieda <[email protected]> Signed-off-by: Armando Visconti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In lis2dux12_set_odr(), the call to stmemsc module lis2dux12_mode_set() API is done with the .fs field left uninitialized, so setting the underlying device regs in an unproper way.
Suggested by: @ubieda
Depends to #76279 and must be rebased once that will be merged.