Implement readout protection for STM32H7 #76640

FRASTM · 2024-08-02T11:44:55Z

following the #76097

This one is adding the READOUT protection (RDP) for the stm32h7 serie

Tested on the stm32h745i disco with tests/drivers/flash/stm32/ with CONFIG_FLASH_STM32_READOUT_PROTECTION=y

*** Booting Zephyr OS build v3.7.0-449-ge7cd0f0307a2 ***                                                               
Running TESTSUITE flash_stm32                                                                                          
===================================================================                                                    
START - test_stm32_readout_protection_disabled                                                                         
RDP is disabled                                                                                                        
 PASS - test_stm32_readout_protection_disabled in 0.002 seconds                                                        
===================================================================                                                    
TESTSUITE flash_stm32 succeeded                                                                                        
                                                                                                                       
------ TESTSUITE SUMMARY START ------                                                                                  
                                                                                                                       
SUITE PASS - 100.00% [flash_stm32]: pass = 1, fail = 0, skip = 0, total = 1 duration = 0.002 seconds                   
 - PASS - [flash_stm32.test_stm32_readout_protection_disabled] duration = 0.002 seconds                                
                                                                                                                       
------ TESTSUITE SUMMARY END ------                                                                                    
                                                                                                                       
===================================================================                                                    
PROJECT EXECUTION SUCCESSFUL

FRASTM · 2024-08-02T11:50:58Z

Also tested on the stm32h750b_dk to answer the #76297

drivers/flash/flash_stm32.h

drivers/flash/flash_stm32h7x.c

drivers/flash/flash_stm32_ex_op.c

duda-patryk · 2024-08-23T10:39:30Z

@FRASTM Is there any progress on that? I'm interested in support for RDP and WP for STM32H7 chips

FRASTM · 2024-09-02T12:31:00Z

Changed with common ex_op functions for stm32h7 and other series
Fix build error with google_dragonclaw (stm32F4)

erwango · 2024-09-05T09:22:27Z

@benediktibk Thanks for the initial review on this. Would you mind resolving conversations on addressed points when you have some free cycles ?

benediktibk · 2024-09-05T11:55:12Z

@benediktibk Thanks for the initial review on this. Would you mind resolving conversations on addressed points when you have some free cycles ?

Done, but I was only able to comment on the reviews where they were done. As I am neither the PR owner nor have write access to the repo github won't let me resolve my own conversations :-|

niedzwiecki-dawid · 2024-10-11T07:04:47Z

Can I somehow help to get this merged? :-)

drivers/flash/flash_stm32.h

drivers/flash/flash_stm32.c

drivers/flash/flash_stm32h7x.c

Place the flash_stm32_sem_take and flash_stm32_sem_give function to header file for common to use in any flash driver Signed-off-by: Francois Ramu <[email protected]>

Move the stm32 flash driver ex_op functions to common flash_stm32_ex_op.c file. Signed-off-by: Francois Ramu <[email protected]>

Implement the readout protection for the STM32H7 series. Define the specific functions used by the flash_stm32h7. Move the stm32h7 flash register manipulation in a write_optb() to be called by the flash_stm32_set_rdp_level. Signed-off-by: Francois Ramu <[email protected]>

FRASTM · 2024-11-28T15:15:22Z

drivers: flash: stm32h7 flash has a write_optb function to set rdp level squash into drivers: flash: stm32h7 with RDP protection
remove reference to H7 serie in the first change of flash_stm32.c
restore the #if defined(CONFIG_MULTITHREADING) || defined(CONFIG_STM32H7_DUAL_CORE)
rebase

benediktibk · 2024-12-03T08:00:32Z

Minor issue, but there are still the copy paste left-overs for the licensing, see my comments above.

FRASTM · 2024-12-04T16:03:15Z

Minor issue, but there are still the copy paste left-overs for the licensing, see my comments above.

Sorry @benediktibk I cannot retrieve that, could you please point it ?

benediktibk · 2024-12-06T08:05:32Z

The review comments are actually still open, they are about the *.overlay files in this PR. In there you still have SILA in the license information, probably a copy-paste leftover.

Add the configuration to run the testcase with READOUT_PROTECTION (RDP) on stm32h7 disco kits Signed-off-by: Francois Ramu <[email protected]>

FRASTM · 2024-12-06T13:52:45Z

The review comments are actually still open, they are about the *.overlay files in this PR. In there you still have SILA in the license information, probably a copy-paste leftover.

Ok I see, correcting

tests/drivers/flash/stm32/boards/stm32h735g_disco.overlay

tests/drivers/flash/stm32/boards/stm32h745i_disco_stm32h745xx_m7.overlay

tests/drivers/flash/stm32/boards/stm32h750b_dk.overlay

drivers/flash/flash_stm32h7x.c

drivers/flash/flash_stm32.h

niedzwiecki-dawid · 2024-12-17T11:13:32Z

drivers/flash/flash_stm32h7x.c

+		return rc;
+	}
+
+	regs->OPTCR = (regs->OPTCR & ~mask) | value;


Shouldn't OPTSR_PRG be used here? Sorry for late comment.

@FRASTM ping :-)

MaazSk · 2025-01-28T07:06:00Z

Sorry for late comment I tried the test on stm32h750b_dk but I got the following error. The error was 134 which means Not supported.

FRASTM mentioned this pull request Aug 2, 2024

Implement readout protection for STM32F7 #76097

Merged

FRASTM force-pushed the stm32h7_rdp branch from e7cd0f0 to 4d87e20 Compare August 2, 2024 11:49

FRASTM requested review from benediktibk, duda-patryk and erwango August 2, 2024 11:54

FRASTM force-pushed the stm32h7_rdp branch 2 times, most recently from 4bfa791 to 5a24884 Compare August 2, 2024 12:20

FRASTM added area: Flash platform: STM32 ST Micro STM32 labels Aug 6, 2024

benediktibk reviewed Aug 6, 2024

View reviewed changes

duda-patryk reviewed Aug 6, 2024

View reviewed changes

drivers/flash/flash_stm32_ex_op.c Outdated Show resolved Hide resolved

FRASTM force-pushed the stm32h7_rdp branch 3 times, most recently from 5956fa8 to 06e9555 Compare September 2, 2024 12:11

FRASTM force-pushed the stm32h7_rdp branch 3 times, most recently from 48d33e4 to d2bb852 Compare September 4, 2024 13:21

FRASTM marked this pull request as ready for review September 5, 2024 07:06

zephyrbot requested review from GeorgeCGV, de-nordic, gautierg-st, marwaiehm-st and mathieuchopstm September 5, 2024 07:07

zephyrbot assigned de-nordic Sep 5, 2024

FRASTM mentioned this pull request Nov 25, 2024

stm32 flash read out protection rdp in a common file #81876

Merged

duda-patryk requested changes Nov 27, 2024

View reviewed changes

drivers/flash/flash_stm32.h Outdated Show resolved Hide resolved

drivers/flash/flash_stm32.c Outdated Show resolved Hide resolved

drivers/flash/flash_stm32h7x.c Outdated Show resolved Hide resolved

FRASTM force-pushed the stm32h7_rdp branch from 8fb0cef to db8a46c Compare November 28, 2024 15:03

FRASTM added 3 commits November 28, 2024 16:06

drivers: flash: stm32 driver move sem functions for multithread

ff0f1e5

Place the flash_stm32_sem_take and flash_stm32_sem_give function to header file for common to use in any flash driver Signed-off-by: Francois Ramu <[email protected]>

drivers: flash: stm32 flash ex op functions are common

d4e9ca2

Move the stm32 flash driver ex_op functions to common flash_stm32_ex_op.c file. Signed-off-by: Francois Ramu <[email protected]>

FRASTM force-pushed the stm32h7_rdp branch from db8a46c to 87f2aee Compare November 28, 2024 15:12

duda-patryk previously approved these changes Dec 2, 2024

View reviewed changes

niedzwiecki-dawid previously approved these changes Dec 3, 2024

View reviewed changes

fabiobaltieri assigned erwango and unassigned de-nordic Dec 6, 2024

tests: drivers: flash RDP testing on stm32h7

e655141

Add the configuration to run the testcase with READOUT_PROTECTION (RDP) on stm32h7 disco kits Signed-off-by: Francois Ramu <[email protected]>

FRASTM dismissed stale reviews from niedzwiecki-dawid and duda-patryk via e655141 December 6, 2024 13:52

FRASTM force-pushed the stm32h7_rdp branch from 87f2aee to e655141 Compare December 6, 2024 13:52

FRASTM requested review from duda-patryk and niedzwiecki-dawid December 6, 2024 13:53

niedzwiecki-dawid approved these changes Dec 6, 2024

View reviewed changes

duda-patryk approved these changes Dec 6, 2024

View reviewed changes

benediktibk approved these changes Dec 9, 2024

View reviewed changes

erwango approved these changes Dec 9, 2024

View reviewed changes

kartben merged commit df86315 into zephyrproject-rtos:main Dec 9, 2024
24 checks passed

FRASTM mentioned this pull request Dec 11, 2024

drivers: flash: stm32wba flash driver moves sem functions #82861

Merged

niedzwiecki-dawid reviewed Dec 17, 2024

View reviewed changes

Implement readout protection for STM32H7 #76640

Implement readout protection for STM32H7 #76640

Uh oh!

Conversation

FRASTM commented Aug 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FRASTM commented Aug 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

duda-patryk commented Aug 23, 2024

Uh oh!

FRASTM commented Sep 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erwango commented Sep 5, 2024

Uh oh!

benediktibk commented Sep 5, 2024

Uh oh!

niedzwiecki-dawid commented Oct 11, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FRASTM commented Nov 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benediktibk commented Dec 3, 2024

Uh oh!

FRASTM commented Dec 4, 2024

Uh oh!

benediktibk commented Dec 6, 2024

Uh oh!

FRASTM commented Dec 6, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

niedzwiecki-dawid Dec 17, 2024

Choose a reason for hiding this comment

Uh oh!

niedzwiecki-dawid Jan 17, 2025

Choose a reason for hiding this comment

Uh oh!

MaazSk commented Jan 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

FRASTM commented Aug 2, 2024 •

edited

Loading

FRASTM commented Aug 2, 2024 •

edited

Loading

FRASTM commented Sep 2, 2024 •

edited

Loading

FRASTM commented Nov 28, 2024 •

edited

Loading