[Backport v3.7-branch] kernel: fatal: Fix NO_OPTIMIZATIONS build (logging + no multithreading) #76810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When logging is on and optimization and multithreading is off then build fails to link because unoptimized compiler/linker seems to not look beyond the function and it fails trying to link k_thread_name_get. Reworking the code to make it known to the compiler without optimization that k_thread_name_get is not needed and not logging current thread name in that case. Signed-off-by: Krzysztof Chruściński <[email protected]> (cherry picked from commit 28b4bab)
zephyrbot
requested review from
TaiJuWu,
andyross,
ceolin,
cfriedt,
dcpleung,
nashif,
npitre and
peter-mitsis
peter-mitsis
approved these changes
Sep 18, 2024
|
This needs a bug report in order to get backported. |
cfriedt
approved these changes
Nov 4, 2024
nashif
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 28b4bab from #75585.