Skip to content

DRV2605 DT Property Cleanup #76969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nashif merged 8 commits into from
Aug 20, 2024
Merged

DRV2605 DT Property Cleanup #76969

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
79f0520
dts: haptics: drv2605: Documents GPIOs
rriveramcrus Aug 12, 2024
a67d668
drivers: haptics: drv2605: Drops ti prefix from DT props
rriveramcrus Aug 12, 2024
ab9b469
drivers: haptics: drv2605: Drops unused drv2605_pm_state
rriveramcrus Aug 12, 2024
9b1da2d
dts: bindings: drv2605: Requires actuator-mode prop
rriveramcrus Aug 15, 2024
4ac9a9b
drivers: haptics: drv2605: Pick up property defaults from DT
rriveramcrus Aug 13, 2024
edf9eeb
drivers: haptics: drv2605: Introduces rated voltage prop
rriveramcrus Aug 13, 2024
68ba032
drivers: haptics: drv2605: Introduces overdrive clamp prop
rriveramcrus Aug 13, 2024
341aeeb
drivers: haptics: drv2605: Hard codes open loop mode for LRA mode
rriveramcrus Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions drivers/haptics/drv2605.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,11 +601,11 @@ static const struct haptics_driver_api drv2605_driver_api = {
\
static const struct drv2605_config drv2605_config_##inst = { \
.i2c = I2C_DT_SPEC_INST_GET(inst), \
.en_gpio = GPIO_DT_SPEC_INST_GET_OR(inst, ti_en_gpios, {}), \
.in_trig_gpio = GPIO_DT_SPEC_INST_GET_OR(inst, ti_in_trig_gpios, {}), \
.feedback_brake_factor = DT_INST_ENUM_IDX_OR(inst, ti_feedback_brake_factor, 3), \
.loop_gain = DT_INST_ENUM_IDX_OR(inst, ti_loop_gain, 2), \
.actuator_mode = DT_INST_ENUM_IDX_OR(inst, ti_actuator_mode, 0), \
.en_gpio = GPIO_DT_SPEC_INST_GET_OR(inst, en_gpios, {}), \
.in_trig_gpio = GPIO_DT_SPEC_INST_GET_OR(inst, in_trig_gpios, {}), \
.feedback_brake_factor = DT_INST_ENUM_IDX_OR(inst, feedback_brake_factor, 3), \
.loop_gain = DT_INST_ENUM_IDX_OR(inst, loop_gain, 2), \
.actuator_mode = DT_INST_ENUM_IDX_OR(inst, actuator_mode, 0), \
Copy link
Contributor

@kartben kartben Aug 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default values should actually be set (and maybe more importantly, documented) in the binding... I think?

Copy link
Contributor

@kartben kartben Aug 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I know this is not strictly related to this change, but I missed it in initial review and am catching this now as I'm actually starting to play with the driver). Thanks!

Copy link
Contributor Author

@rriveramcrus rriveramcrus Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default values should actually be set (and maybe more importantly, documented) in the binding... I think?

Will do!

as I'm actually starting to play with the driver

Don't have too much fun buzzing around.

}; \
\
static struct drv2605_data drv2605_data_##inst = { \
Expand Down
6 changes: 6 additions & 0 deletions dts/bindings/haptics/ti,drv2605.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,9 @@ properties:
- "MEDIUM"
- "HIGH"
- "VERY_HIGH"
en-gpios:
type: phandle-array
description: GPIO to enable and disable the device.
in-trig-gpios:
type: phandle-array
description: GPIO to trigger ROM waveforms or drive an input signal.