Skip to content

Conversation

@mertvatansever
Copy link
Contributor

This PR adds PWM driver for ADI MAX32xxx series microcontrollers. Test overlays for "pwm_api" are provided for each board.

@zephyrbot zephyrbot added area: PWM Pulse Width Modulation platform: ADI Analog Devices, Inc. area: Timer Timer labels Aug 13, 2024
@github-actions
Copy link

Hello @mertvatansever, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of 2023, should be 2023-2024, please apply it for all cases in this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timer4/5 generally low power timers, the name of the node shall be lptimer0/1 as device UG.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@ozersa ozersa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall be merged after #76593 being merged, due to similar commits.

@mertvatansever mertvatansever force-pushed the add-MAX32xxx-PWM branch 2 times, most recently from 026bf91 to 3b6f7e2 Compare August 20, 2024 14:24
@mertvatansever
Copy link
Contributor Author

Twister failure will be resolved, when this PR will be merged.

@MaureenHelm
Copy link
Member

Twister failure will be resolved, when this PR will be merged.

Please follow https://docs.zephyrproject.org/latest/develop/modules.html#process-for-submitting-changes-to-existing-modules to verify the HAL change before merging it.

@zephyrbot
Copy link

zephyrbot commented Aug 22, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_adi DNM This PR should not be merged (Do Not Merge) labels Aug 22, 2024
@mertvatansever
Copy link
Contributor Author

Twister failure will be resolved, when this PR will be merged.

Please follow https://docs.zephyrproject.org/latest/develop/modules.html#process-for-submitting-changes-to-existing-modules to verify the HAL change before merging it.

Update in hal_adi is pointed out in manifest.

Common pwm driver for MAX32xxx MCUs

Co-authored-by: Mert Ekren <[email protected]>
Co-authored-by: Mert Vatansever <[email protected]>
Signed-off-by: Sadik Ozer <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this line be consistent, you should use one of them either this

| PWM | on-chip | pwm
or
| Timer | on-chip | counter, pwm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ozersa
Copy link
Contributor

ozersa commented Sep 18, 2024

Please check commit messages after rebase, some of them need to be updated to demonstrate addition,
Like 15478af
commit:

dts: arm: adi: Add Timer instance to MAX32655
Add timer and pwm yml files
TIMER0/1/2/3 support pwm, LPTIMER0/1 not.
LPTIMER0/1 provide 16bits out that not meet pwm requirement.

Should be updated as "Add PWM sub node" due to timer node and related .yml file already there, the commit adds PWM sub node.

ozersa and others added 15 commits September 19, 2024 14:38
Add pwm yml file.
TIMER0/1/2/3 support pwm, LPTIMER0/1 not.
LPTIMER0/1 provide 16bits out that not meet pwm requirement.

Co-authored-by: Mert Vatansever <[email protected]>
Signed-off-by: Sadik Ozer <[email protected]>
PWM added in MAX32655EVKIT and MAX32655FTHR boards file

Signed-off-by: Sadik Ozer <[email protected]>
Add MAX32655EVKIT and MAX32655FTHR pwm overlay file

Signed-off-by: Sadik Ozer <[email protected]>
PWM added in MAX32666EVKIT and MAX32666FTHR boards file

Signed-off-by: Sadik Ozer <[email protected]>
Add MAX32666FTHR and MAX32666EVKIT pwm overlay file

Co-authored-by: Furkan Akkiz <[email protected]>
Signed-off-by: Sadik Ozer <[email protected]>
Add pwm in 'index.rst' and '.yaml' file of MAX32690EVKIT.

Signed-off-by: Furkan Akkiz <[email protected]>
Enable PWM test for MAX32690EVKIT.

Signed-off-by: Furkan Akkiz <[email protected]>
Add PWM into 'index.rst' and '.yaml' files.

Signed-off-by: Mert Ekren <[email protected]>
Enable PWM test for MAX32670EVKIT.

Signed-off-by: Mert Ekren <[email protected]>
Add pwm in 'index.rst' and '.yaml' file of MAX32672 boards.

Signed-off-by: Furkan Akkiz <[email protected]>
Enable PWM test for MAX32672 boards.

Signed-off-by: Furkan Akkiz <[email protected]>
Add PWM into 'index.rst' and '.yaml' files.

Signed-off-by: Mert Ekren <[email protected]>
Enable PWM test for MAX32675EVKIT.

Signed-off-by: Mert Ekren <[email protected]>
Add pwm in 'index.rst' and '.yaml' file of MAX32662EVKIT.

Signed-off-by: Furkan Akkiz <[email protected]>
Enable PWM test for MAX32662EVKIT.

Signed-off-by: Furkan Akkiz <[email protected]>
@mertvatansever
Copy link
Contributor Author

Please check commit messages after rebase, some of them need to be updated to demonstrate addition, Like 15478af commit:

dts: arm: adi: Add Timer instance to MAX32655
Add timer and pwm yml files
TIMER0/1/2/3 support pwm, LPTIMER0/1 not.
LPTIMER0/1 provide 16bits out that not meet pwm requirement.

Should be updated as "Add PWM sub node" due to timer node and related .yml file already there, the commit adds PWM sub node.

Done

@mmahadevan108
Copy link
Contributor

@ttmut, can you revisit this PR

@nashif nashif merged commit 6795474 into zephyrproject-rtos:main Sep 23, 2024
@github-actions
Copy link

Hi @mertvatansever!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

@MaureenHelm MaureenHelm deleted the add-MAX32xxx-PWM branch September 23, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: PWM Pulse Width Modulation area: Timer Timer platform: ADI Analog Devices, Inc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants