-
Notifications
You must be signed in to change notification settings - Fork 8.2k
drivers: pwm: Add MAX32xxx PWM driver #77002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: pwm: Add MAX32xxx PWM driver #77002
Conversation
|
Hello @mertvatansever, and thank you very much for your first pull request to the Zephyr project! |
drivers/pwm/Kconfig.max32
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of 2023, should be 2023-2024, please apply it for all cases in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
dts/arm/adi/max32/max32655.dtsi
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Timer4/5 generally low power timers, the name of the node shall be lptimer0/1 as device UG.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
ozersa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall be merged after #76593 being merged, due to similar commits.
97e107d to
83366b0
Compare
026bf91 to
3b6f7e2
Compare
|
Twister failure will be resolved, when this PR will be merged. |
Please follow https://docs.zephyrproject.org/latest/develop/modules.html#process-for-submitting-changes-to-existing-modules to verify the HAL change before merging it. |
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
Update in hal_adi is pointed out in manifest. |
Common pwm driver for MAX32xxx MCUs Co-authored-by: Mert Ekren <[email protected]> Co-authored-by: Mert Vatansever <[email protected]> Signed-off-by: Sadik Ozer <[email protected]>
8e09c92 to
14d215d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this line be consistent, you should use one of them either this
| PWM | on-chip | pwm
or
| Timer | on-chip | counter, pwm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
Please check commit messages after rebase, some of them need to be updated to demonstrate addition,
Should be updated as "Add PWM sub node" due to timer node and related .yml file already there, the commit adds PWM sub node. |
Add pwm yml file. TIMER0/1/2/3 support pwm, LPTIMER0/1 not. LPTIMER0/1 provide 16bits out that not meet pwm requirement. Co-authored-by: Mert Vatansever <[email protected]> Signed-off-by: Sadik Ozer <[email protected]>
PWM added in MAX32655EVKIT and MAX32655FTHR boards file Signed-off-by: Sadik Ozer <[email protected]>
Add MAX32655EVKIT and MAX32655FTHR pwm overlay file Signed-off-by: Sadik Ozer <[email protected]>
PWM added in MAX32666EVKIT and MAX32666FTHR boards file Signed-off-by: Sadik Ozer <[email protected]>
Add MAX32666FTHR and MAX32666EVKIT pwm overlay file Co-authored-by: Furkan Akkiz <[email protected]> Signed-off-by: Sadik Ozer <[email protected]>
Add pwm in 'index.rst' and '.yaml' file of MAX32690EVKIT. Signed-off-by: Furkan Akkiz <[email protected]>
Enable PWM test for MAX32690EVKIT. Signed-off-by: Furkan Akkiz <[email protected]>
Add PWM into 'index.rst' and '.yaml' files. Signed-off-by: Mert Ekren <[email protected]>
Enable PWM test for MAX32670EVKIT. Signed-off-by: Mert Ekren <[email protected]>
Add pwm in 'index.rst' and '.yaml' file of MAX32672 boards. Signed-off-by: Furkan Akkiz <[email protected]>
Enable PWM test for MAX32672 boards. Signed-off-by: Furkan Akkiz <[email protected]>
Add PWM into 'index.rst' and '.yaml' files. Signed-off-by: Mert Ekren <[email protected]>
Enable PWM test for MAX32675EVKIT. Signed-off-by: Mert Ekren <[email protected]>
Add pwm in 'index.rst' and '.yaml' file of MAX32662EVKIT. Signed-off-by: Furkan Akkiz <[email protected]>
Enable PWM test for MAX32662EVKIT. Signed-off-by: Furkan Akkiz <[email protected]>
14d215d to
67558c8
Compare
Done |
|
@ttmut, can you revisit this PR |
|
Hi @mertvatansever! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
This PR adds PWM driver for ADI MAX32xxx series microcontrollers. Test overlays for "pwm_api" are provided for each board.