Bluetooth: Host: Add missing bt_tx_irq_raise()
#77054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth
area: Bluetooth Host
zephyrbot
requested review from
Thalley,
aescolar,
alwa-nordic,
hermabe,
jhedberg,
sjanc and
theob-pro
|
@jori-nordic does this need backporting to 3.7.1? |
The regression was introduced during the 3.7 stabilization I'd say it does. |
jhedberg
previously approved these changes
Aug 14, 2024
Thalley
previously approved these changes
Aug 14, 2024
|
@jori-nordic this needs a rebase now |
jori-nordic
dismissed stale reviews from Thalley, jhedberg, and fabiobaltieri
via
6a06331
jori-nordic
force-pushed
the
tx-frag-fix
branch
from
710b0ca to
6a06331
Compare
fabiobaltieri
previously approved these changes
Aug 16, 2024
|
What's the babblesim CI test failure? |
|
alwa changed the hierarchy of compile.sh. I'll move it in 2sec. |
Verifies that we don't leak connection references when the peer goes out of range whilst we are fragmenting and sending data to the controller. Signed-off-by: Jonathan Rico <[email protected]>
Trigger the TX processor on connection teardown. When a disconnection happens before the controller has acknowledged some ACL fragments the host has sent, we run `process_unack_tx()` to free those unacknowledged buffers and their associated TX contexts. The problem is that the TX processor still holds a reference to the conn object. That reference is not released until the TX processor is triggered again and figures out that the connection is invalid. Signed-off-by: Jonathan Rico <[email protected]>
jori-nordic
force-pushed
the
tx-frag-fix
branch
from
6a06331 to
4a1dc14
Compare
fabiobaltieri
approved these changes
Aug 16, 2024
jhedberg
approved these changes
Aug 16, 2024
Thalley
approved these changes
Aug 16, 2024
aescolar
reviewed
Aug 19, 2024
| Execute "${test_exe}" -v=${verbosity_level} -s=${simulation_id} -d=0 -rs=420 -testid=dut \ | ||
| -argstest log_level 3 | ||
| Execute "${test_exe}" -v=${verbosity_level} -s=${simulation_id} -d=1 -rs=69 -testid=peer \ | ||
| -argstest log_level 3 >/dev/null |
There was a problem hiding this comment.
>/dev/null
was this left due to an oversight? (note you should be able to set the verbosity to 0 and get nothing but warnings out of a device)
There was a problem hiding this comment.
Oversight at first, but then realized logs from the other device are not useful. So I left it there.
I'll use the -v switch next time, sorry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76951