Drivers: Add Bosch bmp180 pressure sensor [v2] #77182

ruehlchris · 2024-08-17T08:04:12Z

Version 2 Pull request for Bosch bmp180 pressure sensor.

merge multiple commits
fixed code style if() {}
fixed camel case
use k_sleep() not k_wait_busy()
i2c.dtsi tests/../sensors/ add the device tree information on the tail with increment number
add comment to make clear why use the custom byte swap for int16_t in bmp180.h

Thank you for your review.

drivers/sensor/bosch/CMakeLists.txt

drivers/sensor/bosch/bmp180/Kconfig

drivers/sensor/bosch/bmp180/bmp180.c

kartben · 2024-08-17T12:20:37Z

@ruehlchris there is already #73218 that is about ready to get in. I would suggest you check it out and maybe provide feedback there if you feel there are things that could be improved . Thanks!

mariopaja · 2024-08-17T12:34:49Z

BMP180 is the newer version of BMP085 and they use the same registers.
Unfortunately, it got blocked and noone replied although all the issues were addressed.

#67612

ruehlchris · 2024-08-18T04:12:23Z

I apply the changes , rebase and force update the branch.

drivers/sensor/bosch/bmp180/bmp180.c

drivers/sensor/bosch/bmp180/bmp180.h

ruehlchris · 2024-08-20T05:05:59Z

Follow the advice to reopen this branch, rebase the fixups.

ruehlchris · 2024-08-20T05:42:05Z

@faxe1008 I'm very sorry - but I synced the branch here i the web interface cause of unresolved issue in the i2c.dtsi, now I rebased and push forced to where I started. But the workflow test will still fail for the one bad 0x8e not my commit. Lets see how I can fix this up later.

ruehlchris · 2024-08-20T10:40:47Z

@faxe1008 I stuck with the build process because
tests/drivers/build_all/sensor/i2c.dtsi has conflict with this branch.
I can rebase and delete the commit for i2c.dtsi only for now.

ruehlchris · 2024-08-26T10:18:57Z

Received a bmp390l today and run side to side test, realized that the bmp180 has the pressure in Pa, and the kPa conversion was wrong. Fixed it.

drivers/sensor/bosch/bmp180/Kconfig

drivers/sensor/bosch/bmp180/bmp180.c

tests/drivers/build_all/sensor/i2c.dtsi

drivers/sensor/bosch/bmp180/bmp180.c

ruehlchris · 2024-08-28T08:19:48Z

Tested the bmp180 against the new arrived bmp390 and the accuracy wasn't great. Find the problem in an
int32_t overrun in my optimized conversion formula. Fixed it and push the fix.

drivers/sensor/bosch/bmp180/bmp180.h

Add driver support for Bosch bmp180 pressure sensor running on i2c bus. It pushes the driver files to the bmp180 directory under drivers/sensor/bosch. The driver implement the Sensor API and support channel DIE_TEMP and PRESSURE. Driver had been tested with the NRF5340DK. V2 fixup --------- Drivers: Bosch bmp180 fixups for PR v2 fix BMP180 in CMakeLists.txt rename regControl to ctrlreg simplify the logic in set_attribute use BMP180_GET_CMD_TEMP_DELAY Drivers: Bosch bmp180 use system byteorder macros To aware of ENDIANESS use the macros from byteorders.h Drivers: Bosch bmp180 comments added to #endif Add a comment to the #endif /* CONFIG_FOO */ Drivers: Bosch bmp180 , fix twister run error twister report an error related to using floor() with a float fix this using floorf() function. Drivers: Bosch bmp180, rework review v2 fix code style issues simplify the structure for bus and i2c. prepare to remove the empty bmp180_i2c.c Drivers: Bosch bmp180, remove bmp180_i2c.c bmp180: update CMakeList.txt remove bmp180_i2c.c bmp180: remove unused variable fixups for complient checks replace homebrew bitshift with byteorder.h macro sys_get_be16 and sys_get_be24 cleanup remove unused spi.h change struct reg16/24 to uint8_t[] remove channel AMBIENT_TEMP bmp180/Kconfig add missing help text fix indent issue in bmp180_pm_action merge BMP180_CONFIG_I2C into BMP180_INST Move DT_DRV_COMPAT out of the header file drop LOG_DBG() from read calibration data remove bus_io implementation and header cleanup move headers and structs out from bmp180.h fix typo in comment apply clang format changes, only if not line lenght violation fix indent code error after joined lines conversion from Pa to kPh was wrong, fixed it Remove default=n from Kconfig, it is the default. Move the conversion ready test into a function (duplicate code) and apply retry policy parameter naming with indicate the usage change BMP180_INST(inst) to clang format fix int32_t overflow in convension formular fix wrong devider in convension formula move BSWAP_s16 BSWAP_u16 from .h to .c Signed-off-by: Chris Ruehl <[email protected]>

Add the yaml files needed for the dts binding of the Bosch bmp180 sensor. V2 Fixup -------- yaml fixup for complient checks merge bmp180-i2c.yaml and bmp180.yaml Signed-off-by: Chris Ruehl <[email protected]>

Add bmp180 test case to tests/drivers/build_all/sensor/i2c.dtsi Signed-off-by: Chris Ruehl <[email protected]>

ruehlchris · 2024-08-29T06:13:42Z

@faxe1008 thank you for your reviews! It was very helpful. Have send an other pull request for merge bmp390 into bmp388 driver. You might have a look if you have time. #77724

github-actions · 2024-08-30T15:47:04Z

Hi @ruehlchris!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

zephyrbot added the area: Sensors Sensors label Aug 17, 2024

zephyrbot requested review from MaureenHelm, avisconti, jeppenodgaard, teburd, tristan-google, ubieda and yperess August 17, 2024 08:04

zephyrbot assigned MaureenHelm Aug 17, 2024

faxe1008 requested changes Aug 17, 2024

View reviewed changes

ruehlchris force-pushed the bmp180_sensor_v2 branch from 6c7917f to e74b1c1 Compare August 18, 2024 04:09

ruehlchris force-pushed the bmp180_sensor_v2 branch 2 times, most recently from ad5efe0 to 62a58b2 Compare August 18, 2024 05:23

ruehlchris mentioned this pull request Aug 18, 2024

drivers: sensor: bosch: add support for bmp180 #73218

Closed

ruehlchris requested a review from faxe1008 August 19, 2024 01:19

ruehlchris force-pushed the bmp180_sensor_v2 branch 2 times, most recently from 39a7a5d to 87994ec Compare August 20, 2024 01:15

ruehlchris closed this Aug 20, 2024

ruehlchris force-pushed the bmp180_sensor_v2 branch from 87994ec to f93e192 Compare August 20, 2024 03:17

faxe1008 requested changes Aug 20, 2024

View reviewed changes

ruehlchris reopened this Aug 20, 2024

ruehlchris force-pushed the bmp180_sensor_v2 branch from 3fcd94b to 2f1da99 Compare August 20, 2024 05:30

ruehlchris force-pushed the bmp180_sensor_v2 branch from 2f1da99 to e5b79cf Compare August 20, 2024 10:09

ruehlchris force-pushed the bmp180_sensor_v2 branch from e5b79cf to ab72b8c Compare August 20, 2024 10:41

ruehlchris force-pushed the bmp180_sensor_v2 branch from 26246c8 to bafc899 Compare August 26, 2024 10:16

faxe1008 previously approved these changes Aug 26, 2024

View reviewed changes

yperess requested changes Aug 26, 2024

View reviewed changes

MaureenHelm reviewed Aug 26, 2024

View reviewed changes

drivers/sensor/bosch/bmp180/bmp180.c Outdated Show resolved Hide resolved

tests/drivers/build_all/sensor/i2c.dtsi Outdated Show resolved Hide resolved

ruehlchris dismissed faxe1008’s stale review via aeb33c2 August 27, 2024 04:12

ruehlchris force-pushed the bmp180_sensor_v2 branch from bafc899 to aeb33c2 Compare August 27, 2024 04:12

ruehlchris requested review from MaureenHelm, faxe1008 and yperess August 27, 2024 07:30

faxe1008 reviewed Aug 27, 2024

View reviewed changes

drivers/sensor/bosch/bmp180/bmp180.c Outdated Show resolved Hide resolved

ruehlchris force-pushed the bmp180_sensor_v2 branch from aeb33c2 to d2975ef Compare August 28, 2024 02:01

ruehlchris requested a review from faxe1008 August 28, 2024 02:05

ruehlchris force-pushed the bmp180_sensor_v2 branch from d2975ef to bbaa411 Compare August 28, 2024 08:18

ruehlchris force-pushed the bmp180_sensor_v2 branch from bbaa411 to 6902ed7 Compare August 28, 2024 09:47

faxe1008 previously approved these changes Aug 28, 2024

View reviewed changes

drivers/sensor/bosch/bmp180/bmp180.h Outdated Show resolved Hide resolved

Chris Ruehl added 3 commits August 29, 2024 08:58

Drivers: Bosch bmp180 dts bindings

9df63a5

Add the yaml files needed for the dts binding of the Bosch bmp180 sensor. V2 Fixup -------- yaml fixup for complient checks merge bmp180-i2c.yaml and bmp180.yaml Signed-off-by: Chris Ruehl <[email protected]>

tests: build_all: sensors: add bmp180@94, i2c.dtsi

9754d70

Add bmp180 test case to tests/drivers/build_all/sensor/i2c.dtsi Signed-off-by: Chris Ruehl <[email protected]>

ruehlchris dismissed faxe1008’s stale review via 9754d70 August 29, 2024 00:59

ruehlchris force-pushed the bmp180_sensor_v2 branch from 6902ed7 to 9754d70 Compare August 29, 2024 00:59

ruehlchris requested a review from faxe1008 August 29, 2024 01:02

faxe1008 approved these changes Aug 29, 2024

View reviewed changes

yperess approved these changes Aug 29, 2024

View reviewed changes

MaureenHelm approved these changes Aug 29, 2024

View reviewed changes

nashif merged commit 8a154da into zephyrproject-rtos:main Aug 30, 2024

MaureenHelm mentioned this pull request Dec 2, 2024

[Coverity CID: 434580] Untrusted divisor in drivers/sensor/bosch/bmp180/bmp180.c #81967

Closed

Drivers: Add Bosch bmp180 pressure sensor [v2] #77182

Drivers: Add Bosch bmp180 pressure sensor [v2] #77182

Uh oh!

Conversation

ruehlchris commented Aug 17, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kartben commented Aug 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mariopaja commented Aug 17, 2024

Uh oh!

ruehlchris commented Aug 18, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ruehlchris commented Aug 20, 2024

Uh oh!

ruehlchris commented Aug 20, 2024

Uh oh!

ruehlchris commented Aug 20, 2024

Uh oh!

ruehlchris commented Aug 26, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ruehlchris commented Aug 28, 2024

Uh oh!

Uh oh!

ruehlchris commented Aug 29, 2024

Uh oh!

github-actions bot commented Aug 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

kartben commented Aug 17, 2024 •

edited

Loading