Skip to content

drivers: sensor: STS4x Add driver #77292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2024
Merged

drivers: sensor: STS4x Add driver #77292

merged 1 commit into from
Nov 16, 2024

Conversation

@jfaeh
Copy link
Contributor

@jfaeh jfaeh commented Aug 20, 2024

This adds support for Sensirion's STS4x temperature sensor

@github-actions
Copy link

Hello @jfaeh, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

jeppenodgaard
jeppenodgaard requested changes Aug 20, 2024
View reviewed changes
Copy link

@jeppenodgaard jeppenodgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!
You need to remove the merge commit - use git rebase.

@jfaeh jfaeh force-pushed the main branch 5 times, most recently from 0b71080 to 6327914 Compare August 21, 2024 12:09
MaureenHelm
MaureenHelm requested changes Aug 21, 2024
View reviewed changes
Copy link
Member

@MaureenHelm MaureenHelm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Please address the failed checks:
https://github.com/zephyrproject-rtos/zephyr/actions/runs/10489554216/job/29054452132?pr=77292#step:11:36

@jfaeh jfaeh force-pushed the main branch 4 times, most recently from 2a2dcfd to e5ded74 Compare August 27, 2024 06:59
@jfaeh
Copy link
Contributor Author

jfaeh commented Aug 28, 2024

@MaureenHelm @jeppenodgaard Done

MaureenHelm
MaureenHelm requested changes Aug 29, 2024
View reviewed changes
Copy link
Member

@MaureenHelm MaureenHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The driver LGTM, but there's already a generic sensor sample that reads ambient temperature (samples/sensor/thermometer). Please use that instead of introducing a new sample.

@jfaeh jfaeh force-pushed the main branch 3 times, most recently from b6df240 to 5d3dd47 Compare September 2, 2024 13:12
jeppenodgaard
jeppenodgaard reviewed Sep 18, 2024
View reviewed changes
Copy link

@jeppenodgaard jeppenodgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase to resolve conflict. Otherwise LGTM.

@jfaeh
Copy link
Contributor Author

jfaeh commented Sep 23, 2024

Needs a rebase to resolve conflict. Otherwise LGTM.

Done

jeppenodgaard
jeppenodgaard previously approved these changes Sep 23, 2024
View reviewed changes
MaureenHelm
MaureenHelm previously approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@MaureenHelm MaureenHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase to resolve conflict. Otherwise LGTM.

Done

Sorry, one more time please.

ubieda
ubieda previously approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@ubieda ubieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, please rebase once more!

@jfaeh jfaeh dismissed stale reviews from ubieda, MaureenHelm, and jeppenodgaard via 53f508f October 21, 2024 06:34
@jfaeh
Copy link
Contributor Author

jfaeh commented Oct 22, 2024

Done @ubieda @MaureenHelm @jeppenodgaard

ubieda
ubieda previously approved these changes Oct 22, 2024
View reviewed changes
jeppenodgaard
jeppenodgaard previously approved these changes Oct 22, 2024
View reviewed changes
@jfaeh
drivers: sensor: STS4x Add driver
6db870d 
This adds support for Sensirion's STS4x temperature sensor.

Signed-off-by: Jan Faeh <[email protected]>
@jfaeh jfaeh dismissed stale reviews from jeppenodgaard and ubieda via 6db870d October 29, 2024 15:29
@jfaeh
Copy link
Contributor Author

jfaeh commented Oct 30, 2024

Rebased once again @ubieda @MaureenHelm @jeppenodgaard

@mmahadevan108 mmahadevan108 added this to the v4.1.0 milestone Nov 1, 2024
@psachs
Copy link

psachs commented Nov 4, 2024

Can someone who is authorized merge this pull request? Since @jfaeh (Jan) is away until next week he can't merge himself until then.

@kartben
Copy link
Contributor

kartben commented Nov 4, 2024

Can someone who is authorized merge this pull request? Since @jfaeh (Jan) is away until next week he can't merge himself until then.

Sorry, this missed the 4.0.0 feature freeze deadline so this will have to wait until 4.1.0 merge window opens.

@nashif nashif merged commit 2294525 into zephyrproject-rtos:main Nov 16, 2024
23 checks passed
@github-actions
Copy link

Hi @jfaeh!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeppenodgaard jeppenodgaard jeppenodgaard approved these changes

@MaureenHelm MaureenHelm MaureenHelm approved these changes

@ubieda ubieda ubieda approved these changes

@avisconti avisconti Awaiting requested review from avisconti

@kartben kartben Awaiting requested review from kartben

@nashif nashif Awaiting requested review from nashif

@teburd teburd Awaiting requested review from teburd

@tristan-google tristan-google Awaiting requested review from tristan-google

@yperess yperess Awaiting requested review from yperess

Assignees

@MaureenHelm MaureenHelm

Labels

area: Samples Samples area: Sensors Sensors

Projects

None yet

Milestone

v4.1.0

Development

Successfully merging this pull request may close these issues.

9 participants

@jfaeh @psachs @kartben @jeppenodgaard @MaureenHelm @ubieda @nashif @mmahadevan108 @zephyrbot