Skip to content

Conversation

@clodnut
Copy link
Contributor

@clodnut clodnut commented Aug 29, 2024

drivers: rtc: rtc_1307.c

Read/modify/write the CH/SECONDS register at initialisation to clear only the Clock Halt bit and only if it is set.

This prevents the SECONDS field(s) from being wiped out unconditionally at initialisation.

Fixes #77354.

@github-actions
Copy link

Hello @clodnut, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@bjarki-andreasen
Copy link
Contributor

Hi, you need to squash your commits and force push the single commit, and make the header of said commit a bit more descriptive :)

@bjarki-andreasen
Copy link
Contributor

Hi, could you rebase and force push? the changes are good, but CI is stuck for whatever reason :)

Copy link
Contributor

@bjarki-andreasen bjarki-andreasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@fabiobaltieri fabiobaltieri added this to the v4.0.0 milestone Oct 28, 2024
@kartben kartben added the bug The issue is a bug, or the PR is fixing a bug label Oct 28, 2024
@bjarki-andreasen
Copy link
Contributor

lastly, please update the signed off entry to match the user you committed with, maybe you user "clodnut" needs to updated with the name in you signed of with?

@clodnut
Copy link
Contributor Author

clodnut commented Oct 30, 2024

lastly, please update the signed off entry to match the user you committed with, maybe you user "clodnut" needs to updated with the name in you signed of with?

Thank you. Updated (I don't believe I can re-trigger the pipeline to confirm).

@kartben
Copy link
Contributor

kartben commented Oct 30, 2024

lastly, please update the signed off entry to match the user you committed with, maybe you user "clodnut" needs to updated with the name in you signed of with?

Thank you. Updated (I don't believe I can re-trigger the pipeline to confirm).

@clodnut did you forget to (force) push your change?

@mmahadevan108
Copy link
Contributor

@clodnut , can you help address the CI compliance check failures.

We read/modify/write the CH/SECONDS register at initialisation to clear
only the Clock Halt bit and only if it is set.

The previous implementation zeroes the entire register unconditionally at
initialisation, which wipes the SECONDS fields.

Fixes #77354.

Signed-off-by: Andrew Feldhaus <[email protected]>
@kartben
Copy link
Contributor

kartben commented Nov 8, 2024

@mmahadevan108 should be good to go now

@mmahadevan108 mmahadevan108 merged commit a2e920c into zephyrproject-rtos:main Nov 8, 2024
23 checks passed
@github-actions
Copy link

github-actions bot commented Nov 8, 2024

Hi @clodnut!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: RTC Real Time Clock bug The issue is a bug, or the PR is fixing a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RTC_DS1307 driver zeroes-out seconds when initialising

6 participants