- 
                Notifications
    
You must be signed in to change notification settings  - Fork 8.2k
 
ADIN2111 OA mode fixes #77832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADIN2111 OA mode fixes #77832
Conversation
| 
           Hello @panekmaciej, and thank you very much for your first pull request to the Zephyr project!  | 
    
29477ca    to
    7625880      
    Compare
  
    b618bc7    to
    b85cbb5      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpmur can you take a look?
| 
           Needs rebase  | 
    
| if (i == chunks) { | ||
| hdr |= ADIN2111_OA_DATA_HDR_EV; | ||
| hdr |= (ctx->oa_cps - 1) << ADIN2111_OA_DATA_HDR_EBO; | ||
| hdr |= ebo << ADIN2111_OA_DATA_HDR_EBO; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When at the last chunk, you should consider adding ebo to cur instead of cur += ctx->oa_cps; (line 397). This would ensure that the frame length passed to the SPI layer is exactly correct, although I don't think this is a functional issue.
| 
           @panekmaciej will you be able to come back to this to address the merge conflicts?  | 
    
          
 Yes, but after the new year.  | 
    
| 
           @panekmaciej please also create a issue for this, so this can also be backported  | 
    
d611e28
      into
      
  
    zephyrproject-rtos:main
  
    
Uh oh!
There was an error while loading. Please reload this page.