-
Notifications
You must be signed in to change notification settings - Fork 8.3k
serial: mchp_xec: Fix uart_xec_irq_tx_complete function
#77834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serial: mchp_xec: Fix uart_xec_irq_tx_complete function
#77834
Conversation
|
CC: @scottwcpg |
scottwcpg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works. Note: old and new code could be simplified. TEMT bit[6] of LSR becomes 1 when both tx holding register AND tx shift register are empty. Depends on your purpose. Are you wanting to know if a new byte can be written to the UART TX reg or are you wanting to know if TX is finished transmitting and no longer requires a clock?
I want to know if TX has finished transmitting and no longer requires clock. In chrome EC, this function is used by |
0302642 to
567d4ea
Compare
|
CC: @keith-zephyr |
This function is only checking for current byte being transmitted. This patch ensures that function returns `1` until TX is disabled and no byte is being transmitted. Signed-off-by: Bernardo Perez Priego <[email protected]>
567d4ea to
22988c3
Compare
|
Ping @jvasanth1 |
This function is only checking for byte current byte being transmitted. This patch ensures that function returns
1until TX is disabled and no byte is being transmitted.