Skip to content

drivers: uhc: implement UHC shim driver for NXP KHCI and EHCI controller #77973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 30, 2025
Merged

drivers: uhc: implement UHC shim driver for NXP KHCI and EHCI controller #77973

merged 4 commits into from
May 30, 2025

Conversation

@MarkWangChinese
Copy link
Contributor

@MarkWangChinese MarkWangChinese commented Sep 4, 2024

Enablet the NXP MCUX UHC drivers.
Add uhc support for frdm_k22f, rt1060, lpc55s69 and lpc55s28. frdm_k22f supports the KHCI controller, rt1060 supports the EHCI controller, lpc55s69 and lpc55s28 support the OHCI and IP3516HS controller.

@zephyrbot zephyrbot added area: ARM ARM (32-bit) Architecture area: Architectures area: USB Universal Serial Bus platform: NXP NXP platform: NXP Drivers NXP Semiconductors, drivers labels Sep 4, 2024
@zephyrbot
Copy link

zephyrbot commented Sep 4, 2024 •
edited by github-actions bot
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@73d478f zephyrproject-rtos/hal_nxp@cea5006 (master) zephyrproject-rtos/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Sep 4, 2024
@PetervdPerk-NXP
Copy link
Contributor

PetervdPerk-NXP commented Sep 4, 2024

Any plans to enable 1170 and 1180 as well?
Since they share almost the same EHCI controller.

@MarkWangChinese MarkWangChinese mentioned this pull request Sep 4, 2024
Closed
@MarkWangChinese
Copy link
Contributor Author

MarkWangChinese commented Sep 4, 2024

Any plans to enable 1170 and 1180 as well? Since they share almost the same EHCI controller.

After this basic NXP UHC controller driver merges, I think next step is implementing the host stack. Because the host stack is not ready, so supporting more platforms does not make much sense.

@jfischer-no
Copy link
Contributor

jfischer-no commented Apr 24, 2025

@MarkWangChinese Please fix style issues reported by compliance checks.

@MarkWangChinese MarkWangChinese force-pushed the feature/enable_mcux_uhc branch 2 times, most recently from d8d68ab to debd1a2 Compare April 25, 2025 07:28
tmon-nordic
tmon-nordic previously approved these changes Apr 25, 2025
View reviewed changes
@MarkWangChinese
Copy link
Contributor Author

MarkWangChinese commented Apr 25, 2025

@MarkWangChinese Please fix style issues reported by compliance checks.

Fixed.

jfischer-no
jfischer-no previously approved these changes Apr 25, 2025
View reviewed changes
@harristomy
Copy link
Contributor

harristomy commented May 12, 2025 •
edited
Loading

@dleach02 @MarkWangChinese any updates on zephyrproject-rtos/hal_nxp#496 ? It'd be great if we can have this feature in Zephyr 4.2

@dleach02 dleach02 dismissed stale reviews from jfischer-no and tmon-nordic via 3ba68f2 May 28, 2025 20:01
@dleach02 dleach02 force-pushed the feature/enable_mcux_uhc branch from debd1a2 to 3ba68f2 Compare May 28, 2025 20:01
@dleach02 dleach02 closed this May 28, 2025
@dleach02 dleach02 reopened this May 28, 2025
@github-actions github-actions bot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label May 28, 2025
@dleach02
Copy link
Member

dleach02 commented May 28, 2025

Merged HAL PR and updated the SHA in west.yml

Need reapplied +1 @jfischer-no @tmon-nordic

@MarkWangChinese @dleach02
drivers: uhc: implement nxp mcux uhc driver
66fb592 
It is based on SDK USB Host controller driver.
Support NXP EHCI, KHCI, OHCI and IP3516HS controllers.

Signed-off-by: Mark Wang <[email protected]>
@MarkWangChinese @dleach02
boards: nxp: add uhc support for frdm_k22f, rt1060, lpc55s69 and lpc5…
80dc12f 
…5s28

add uhc related items to dts.
add clock initialization
add BM4 if CONFIG_USB_UHC_NXP_KHCI is enabled
add pin mux
update board related CMakeLists.txt
update sdk-ng CMake to include NXP controller drivers
update west.yml to contain the hal_nxp pr

Signed-off-by: Mark Wang <[email protected]>
@MarkWangChinese @dleach02
boards: nxp: add uhc support for mimxrt1050_evk
cf942b1 
add uhc related items to dts.

Signed-off-by: Mark Wang <[email protected]>
@MarkWangChinese @dleach02
drivers: uhc: udc: use DYNAMIC_INTERRUPTS for KHCI and EHCI
a0474b6 
Because the same IP supports both device and host, so use
DYNAMIC_INTERRUPTS for KHCI and EHCI if both device and host
are enabled.

Signed-off-by: Mark Wang <[email protected]>
@dleach02 dleach02 force-pushed the feature/enable_mcux_uhc branch from 3ba68f2 to a0474b6 Compare May 29, 2025 14:27
@matt-wood-ct
Copy link
Contributor

matt-wood-ct commented May 29, 2025

Can we have board support for the RT1040?
That's the part I'm using and are keen to test on as classes start to arrive 😄

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 29, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
40.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dleach02
Copy link
Member

dleach02 commented May 29, 2025

Sorry @jfischer-no @tmon-nordic, I needed to rebase to pull in a hot fix from main that was causing CI to fail here. Need your +1 reapplied so we can merge

@kartben kartben merged commit 8951711 into zephyrproject-rtos:main May 30, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfischer-no jfischer-no jfischer-no approved these changes

@dleach02 dleach02 dleach02 approved these changes

@tmon-nordic tmon-nordic tmon-nordic approved these changes

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@bperseghetti bperseghetti Awaiting requested review from bperseghetti

@butok butok Awaiting requested review from butok

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

@dbaluta dbaluta Awaiting requested review from dbaluta

@decsny decsny Awaiting requested review from decsny

@DerekSnell DerekSnell Awaiting requested review from DerekSnell

@EmilioCBen EmilioCBen Awaiting requested review from EmilioCBen

@ithinuel ithinuel Awaiting requested review from ithinuel

@manuargue manuargue Awaiting requested review from manuargue

@PetervdPerk-NXP PetervdPerk-NXP Awaiting requested review from PetervdPerk-NXP

@yvanderv yvanderv Awaiting requested review from yvanderv

Assignees

@jfischer-no jfischer-no

Labels

area: Architectures area: ARM ARM (32-bit) Architecture area: USB Universal Serial Bus manifest manifest-hal_nxp platform: NXP Drivers NXP Semiconductors, drivers platform: NXP NXP

Projects

None yet

Milestone

v4.2.0

Development

Successfully merging this pull request may close these issues.