Skip to content

Conversation

zjian-zhang
Copy link

@zjian-zhang zjian-zhang commented Sep 5, 2024

The amebadplus microcontroller (MCU) is an advanced system-on-chip (SoC) featuring an Arm® Cortex®-M55 and Cortex®-M23, large Flash and SRAM memories, and supports dual-band Wi-Fi 4(2.4GHz + 5GHz) and BLE5.0 specifications.

The initial support for the board includes GPIO, PINCTRL and Loguart(serial).

Copy link

github-actions bot commented Sep 5, 2024

Hello @zjian-zhang, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@zephyrbot
Copy link

zephyrbot commented Sep 5, 2024

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_realtek 🆕 N/A (Added) Ameba-AIoT/nuwa_hal_realtek@5eee68d (rtl8721d) N/A

DNM label due to: 1 added project

Note: This message is automatically posted and updated by the Manifest GitHub Action.

Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read and follow the contribution guidelines https://docs.zephyrproject.org/latest/contribute/guidelines.html#contribute-guidelines we do not shove everything into a single commit for multiple areas, they must be distinct

@decsny decsny removed their request for review September 5, 2024 14:54
@jukkar jukkar removed their request for review September 10, 2024 08:29
@zephyrbot zephyrbot requested a review from de-nordic September 11, 2024 13:19
Copy link

Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

Copy link

Copy link
Contributor

@teburd teburd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked it over, many things beyond my area of maintainership so I'm going to reassign, only one comment from me.

@@ -0,0 +1,88 @@
# Copyright (c) 2024 Realtek Semiconductor Corp.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of 2024 copyrights here, not a big deal to me but it is 2025

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a fair observation! The 2024 reflects when the project was initially created or files were generated. While some projects update yearly and you'll see newly added files dated 2025, others keep the original year. But I appreciate the attention to detail!

Realtek HAL (Hardware Abstraction Layer) provides
a low level peripheral configuration function.

Signed-off-by: zjian zhang <[email protected]>
add initial version of devicetree for amebadplus SOC.
amebadplus devicetree file is main platform dtsi file, which should
be included from board dts (e.g rtl872xda_evb.dts)

Signed-off-by: zjian zhang <[email protected]>
Add initial version of Amebadplus Soc integration

Signed-off-by: zjian zhang <[email protected]>
add amebadplus pin controller driver

Signed-off-by: zjian zhang <[email protected]>
loguart driver for amebadplus

Signed-off-by: zjian zhang <[email protected]>
GPIO driver for amebadplus

Signed-off-by: zjian zhang <[email protected]>
add initial version of rtl872xda_evb board

Signed-off-by: zjian zhang <[email protected]>
This commit adds maintainers for hal_realtek repository

Signed-off-by: zjian zhang <[email protected]>
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants