scripts: Plug TwisterStatus type gaps #78336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszMrugala
added
bug
zephyrbot
requested review from
KamilxPaszkiet,
PerMac,
fabiobaltieri,
gchwier,
golowanow,
hakehuang,
kartben,
nashif and
stephanosio
gchwier
reviewed
Sep 12, 2024
nashif
previously approved these changes
Sep 12, 2024
LukaszMrugala
force-pushed
the
lmrugalx_twisterstatus_get
branch
3 times, most recently
from
5d75f2c to
95e731b
Compare
Some dict.get() calls did not use a TwisterStatus as a default value, thus using a NoneType where TwisterStatus should appear. Signed-off-by: Lukasz Mrugala <[email protected]>
LukaszMrugala
force-pushed
the
lmrugalx_twisterstatus_get
branch
from
95e731b to
c074914
Compare
gchwier
approved these changes
Sep 13, 2024
nashif
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
dict.get()calls did not use aTwisterStatusas a default value, thus using aNoneTypewhereTwisterStatusshould appear.Brought to my attention by @golowanow in a separate issue. Most visible when prematurely ending
TestSuiteexecution while still attempting to create a report.