Skip to content

Conversation

@anthonytw
Copy link
Contributor

…a is ready

Currently the dmic_nrfx_pdm read implementation treats a timeout as an error, in that a logging error message is produced when no PDM data is available. However, for non-(or minimally-)blocking applications this is normal behavior. Classified this way, the logger is flooded with error messages unnecessarily, unless the log level is changed for the dmic module, which is not desirable.

This modification simply changes the log-level to debug so the application user can then decide whether or not a failed read needs to produce an error message.

@anthonytw anthonytw requested a review from anangl as a code owner September 16, 2024 21:14
@github-actions
Copy link

Hello @anthonytw, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

Currently the dmic_nrfx_pdm read implementation treats a timeout as an
error, in that a logging error message is produced when no PDM data is
available. However, for non-(or minimally-)blocking applications this is
normal behavior. Classified this way, the logger is flooded with error
messages unnecessarily, unless the log level is changed for the dmic
module, which is not desirable.

This modification simply changes the log-level to debug so the
application user can then decide whether or not a failed read needs to
produce an error message.

Signed-off-by: Anthony Wertz <[email protected]>
@kartben kartben force-pushed the anthonytw-patch-dmic-read-error branch from 10b5fa4 to add0371 Compare November 18, 2024 18:20
@zephyrbot zephyrbot added area: Audio size: XS A PR changing only a single line of code platform: nRF Nordic nRFx labels Nov 18, 2024
@nashif nashif merged commit a1474a9 into zephyrproject-rtos:main Nov 19, 2024
29 checks passed
@github-actions
Copy link

Hi @anthonytw!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Audio platform: nRF Nordic nRFx size: XS A PR changing only a single line of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants