Skip to content

Conversation

avisconti
Copy link
Contributor

Since the mkbox board ble f/w upgrade method based on binary blobs that was proposed in #74255 has been turned down, all the work done in hal_stm32 module to host blobs is now reverted.

The application will be pushed as part of https://github.com/STMicroelectronics/stsw-mkbox-bleco.git package

@avisconti avisconti self-assigned this Sep 17, 2024
@zephyrbot zephyrbot added the size: XS A PR changing only a single line of code label Sep 17, 2024
@zephyrbot
Copy link

zephyrbot commented Sep 17, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_stm32 zephyrproject-rtos/hal_stm32@c4099c2 zephyrproject-rtos/hal_stm32@1ff8205 (main) zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

fabiobaltieri
fabiobaltieri previously approved these changes Sep 17, 2024
Copy link
Member

@fabiobaltieri fabiobaltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x

Assuming it's intentional that this contains all of these changes as well (in addition to the blob revert one)

jhedberg
jhedberg previously approved these changes Sep 17, 2024
@erwango
Copy link
Member

erwango commented Sep 18, 2024

Assuming it's intentional that this contains all of these changes as well (in addition to the blob revert one)

Actually, we have #76868 in the queue already, which is already the factorization of 3 changes. So I'd prefer this one is merged first as it has the merit of listing the including changes.

@fabiobaltieri
Copy link
Member

Needs a rebase now.

erwango
erwango previously approved these changes Sep 18, 2024
@avisconti
Copy link
Contributor Author

avisconti commented Sep 18, 2024

Assuming it's intentional that this contains all of these changes as well (in addition to the blob revert one)

Actually, we have #76868 in the queue already, which is already the factorization of 3 changes. So I'd prefer this one is merged first as it has the merit of listing the including changes.

Not really intentional, but I was in fact waiting from a comment from @erwango.
OK, I'll rebase it, thx

Since the mkbox board ble f/w upgrade method based on binary
blobs that was proposed in zephyrproject-rtos#74255 has been turned down, all
the work done in hal_stm32 module to host blobs is now reverted.

Signed-off-by: Armando Visconti <[email protected]>
@avisconti avisconti dismissed stale reviews from erwango, jhedberg, and fabiobaltieri via c0ae431 September 18, 2024 09:59
@carlescufi carlescufi merged commit 661975d into zephyrproject-rtos:main Sep 19, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manifest manifest-hal_stm32 platform: STM32 ST Micro STM32 size: XS A PR changing only a single line of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants