Skip to content

Conversation

@soburi
Copy link
Member

@soburi soburi commented Sep 17, 2024

Add build tests for following devices.

  • galaxycore,gc2145

@soburi soburi changed the title Add devices for build all video tests: drivers: build_all: video: Add i2c-devices build test Sep 17, 2024
@kartben
Copy link
Contributor

kartben commented Sep 18, 2024

You may please drop the first commit. See #78431. Thanks for catching this though! Note that this wouldn't have required a release note / migration guide entry as the driver is new anyway.

Add build tests for following devices.

- galaxycore,gc2145

Signed-off-by: TOKITA Hiroshi <[email protected]>
@soburi soburi force-pushed the add_devices_for_build_all_video branch from 57f247a to d841634 Compare September 18, 2024 00:33
@soburi
Copy link
Member Author

soburi commented Sep 18, 2024

You may please drop the first commit. See #78431. Thanks for catching this though! Note that this wouldn't have required a release note / migration guide entry as the driver is new anyway.

Thank you for your notification. Update done.

@soburi soburi marked this pull request as ready for review September 18, 2024 01:22
@zephyrbot zephyrbot added the area: Video Video subsystem label Sep 18, 2024
Copy link
Contributor

@josuah josuah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @soburi for pointing this out.
I believe I forgot to verify that there were tests for each driver submitted. I will make sure there are at least build_all tests in future contributions.

@josuah josuah added area: Devicetree area: Tests Issues related to a particular existing or missing test labels Sep 18, 2024
@henrikbrixandersen henrikbrixandersen merged commit 512f237 into zephyrproject-rtos:main Sep 20, 2024
@soburi soburi deleted the add_devices_for_build_all_video branch September 21, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Devicetree area: Tests Issues related to a particular existing or missing test area: Video Video subsystem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants