Skip to content

drivers: spi_mcux_lpspi: clang-format #78783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
carlescufi merged 1 commit into from
Oct 10, 2024
Merged

drivers: spi_mcux_lpspi: clang-format #78783

carlescufi merged 1 commit into from
Oct 10, 2024

Conversation

@decsny
Copy link
Member

@decsny decsny commented Sep 20, 2024

Clang format the lpspi driver.

@zephyrbot zephyrbot added area: SPI SPI bus platform: NXP Drivers NXP Semiconductors, drivers labels Sep 20, 2024
@decsny decsny added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Sep 20, 2024
@decsny decsny requested a review from pdgendt September 20, 2024 19:28
@danieldegrasse
Copy link
Contributor

danieldegrasse commented Sep 20, 2024

Checkpatch and clang-format seem to be in disagreement

image

@decsny decsny mentioned this pull request Sep 21, 2024
Merged
@decsny decsny force-pushed the lpspi_clang_format branch 2 times, most recently from 7c6edcb to fb371ea Compare September 21, 2024 01:20
@pdgendt
Copy link
Contributor

pdgendt commented Sep 23, 2024 •
edited
Loading

Checkpatch and clang-format seem to be in disagreement

PTAL #78522

pdgendt
pdgendt previously approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@pdgendt pdgendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically we avoid these formatting commits to preserve file history, but given #78789 touches most of the file anyways, I think it's fine.

danieldegrasse
danieldegrasse previously approved these changes Sep 23, 2024
View reviewed changes
@pdgendt
Copy link
Contributor

pdgendt commented Sep 30, 2024

Conflicts need to resolved.

drivers: spi_mcux_lpspi: clang-format
4022b2c 
Clang format the lpspi driver.

Signed-off-by: Declan Snyder <[email protected]>
@decsny decsny dismissed stale reviews from danieldegrasse and pdgendt via 4022b2c October 7, 2024 18:26
@decsny decsny force-pushed the lpspi_clang_format branch from fb371ea to 4022b2c Compare October 7, 2024 18:26
@carlescufi carlescufi merged commit a6eb068 into zephyrproject-rtos:main Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teburd teburd teburd approved these changes

@tbursztyka tbursztyka tbursztyka approved these changes

@pdgendt pdgendt pdgendt approved these changes

@danieldegrasse danieldegrasse danieldegrasse approved these changes

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@dleach02 dleach02 Awaiting requested review from dleach02

@dbaluta dbaluta Awaiting requested review from dbaluta

@manuargue manuargue Awaiting requested review from manuargue

@MarkWangChinese MarkWangChinese Awaiting requested review from MarkWangChinese

Assignees

@tbursztyka tbursztyka

@mmahadevan108 mmahadevan108

Labels

area: SPI SPI bus platform: NXP Drivers NXP Semiconductors, drivers Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@decsny @danieldegrasse @pdgendt @teburd @tbursztyka @carlescufi @mmahadevan108 @zephyrbot