linker: Include the .ARM.extab section for Rust #78901
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a little complicated. We currently just jump directly to rust's panic handler, so we don't actually need these unwind tables. But, they would be needed if we ever really handle panic. As of the time of this change, the tables seem to just be 24 bytes of ROM space. In Rust, unwind tables are not used for ordinary code, but for recovery from panic. Signed-off-by: David Brown <[email protected]>
zephyrbot
added
size: XS
zephyrbot
requested review from
bbolen,
carlocaione,
dcpleung,
galak,
ithinuel,
MaureenHelm,
microbuilder and
nashif
|
This change likely won't be able to merge until #78306 merges, as it hits a compliance failure due to the |
|
Another option would be to just include this as part of #78306, so that both are brought in together. Although the simple tests in the current module do not provoke the failure, most non-trivial work on the module will require this. |
|
Including this inside of #78306. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a little complicated. We currently just jump directly to rust's panic handler, so we don't actually need these unwind tables. But, they would be needed if we ever really handle panic. As of the time of this change, the tables seem to just be 24 bytes of ROM space.
In Rust, unwind tables are not used for ordinary code, but for recovery from panic.