Support QSPI Flash driver for Renesas RA6 devices #78959

thaoluonguw · 2024-09-24T19:21:30Z

Add support for QSPI Flash driver for RA6 devices

Add QSPI Flash driver support on EK_RA6M5, EK_RA6M4, EK_RA6M3 and EK_RA6E2.

zephyrbot · 2024-09-24T19:22:26Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

include/zephyr/drivers/flash/ra_flash_api_extensions.h

dts/bindings/mtd/renesas,ra-qspi-nor.yaml

de-nordic

Issue with EX_OP and mostly nits regarding other areas.

de-nordic · 2024-10-15T14:58:36Z

drivers/flash/flash_qspi_renesas_ra.h

We fixed it. We changed to use macros in https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/flash/spi_nor.h

de-nordic · 2024-10-15T14:58:53Z

drivers/flash/flash_qspi_renesas_ra.h

This isn't typo. We mentioned QPI mode (4-4-4) here.

de-nordic · 2024-10-15T15:02:45Z

drivers/flash/flash_qspi_renesas_ra.h

Most of those defines are actually provided here https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/flash/spi_nor.h, I know the naming is SPI_NOR, but adding additional defines only brings new names for functionally the same things.
You could just use the SPI_NOR defines and define these that are not provided by the header.

We changed to use macros in https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/flash/spi_nor.h

de-nordic · 2024-10-15T15:06:46Z

include/zephyr/drivers/flash/ra_flash_api_extensions.h

There is already system wide id for reset
FLASH_EX_OP_RESET = 0

zephyr/include/zephyr/drivers/flash.h

Line 640 in 03959a2

FLASH_EX_OP_RESET = 0,

and if the meaning is the same, the system wide one should be used.

We fixed it as your advice.

de-nordic · 2024-10-15T15:09:18Z

include/zephyr/drivers/flash/ra_flash_api_extensions.h

This define is in the same range as system wide definition for non-vendor space, and as such is not allowed.
Please refer to

zephyr/include/zephyr/drivers/flash.h

Lines 617 to 631 in 03959a2

/*

* Extended operation interface provides flexible way for supporting flash

* controller features. Code space is divided equally into Zephyr codes

* (MSb == 0) and vendor codes (MSb == 1). This way we can easily add extended

* operations to the drivers without cluttering the API or problems with API

* incompatibility. Extended operation can be promoted from vendor codes to

* Zephyr codes if the feature is available in most flash controllers and

* can be represented in the same way.

*

* It's not forbidden to have operation in Zephyr codes and vendor codes for

* the same functionality. In this case, vendor operation could provide more

* specific access when abstraction in Zephyr counterpart is insufficient.

*/

#define FLASH_EX_OP_VENDOR_BASE 0x8000

#define FLASH_EX_OP_IS_VENDOR(c) ((c) & FLASH_EX_OP_VENDOR_BASE)

for instruction on how to define vendor specific operation
and to https://github.com/zephyrproject-rtos/zephyr/blob/03959a20f7834ffe50a51df2b2e45ef87d1b610b/include/zephyr/drivers/flash/stm32_flash_api_extensions.h for an example of such definition.

I think that there is also typo and QPI should be QSPI?

We updated for "QSPI_FLASH_EX_OP_EXIT_QPI" as your advice.
And "QPI" isn't typo. We mentioned QPI mode (4-4-4).

de-nordic · 2024-10-15T15:12:57Z

drivers/flash/flash_qspi_renesas_ra.c

You probably want to have some logging in at least one of the ifs, otherwise you have the same error returned to user with no way to distinguish problems except for debugging.

We fixed it. We added log to distinguish for errors.

de-nordic · 2024-10-15T15:15:45Z

drivers/flash/flash_qspi_renesas_ra.c

You lack here userspace processing, is that desired?

Yes, it is designed without userspace processing.
It is supported to reset QPI mode and memory.

de-nordic · 2024-10-15T15:20:06Z

drivers/flash/flash_qspi_renesas_ra.c

Here you fail operation of -EINVAL, even if len == 0 would cause nothing happening at all,
on the other side in qspi_flash_ra_write you first check len == 0 and bypass any more checks as there is no more work to.

Consider having one flow everywhere, for example checking the len == 0 and just exit as there is no work to do and actually no possibility to failure

We fixed it. We unified one flow for both qspi_flash_ra_write() and qspi_flash_ra_read(): check "len == 0" first and just exit.

de-nordic · 2024-10-15T15:21:50Z

There is a lot of QPI in the code, shouldn't that be QSPI?

thaoluonguw · 2024-10-21T08:51:52Z

There is a lot of QPI in the code, shouldn't that be QSPI?

@de-nordic : Thank you so much for your review. We fixed issues which you pointed out.
Please check the updates at: https://github.com/zephyrproject-rtos/zephyr/compare/81878488837d751b4711ff629a61c9c098011dce..f462ce16a76f505fde14c40293db08f204f108a2

For "QPI" in the code, it isn't typo of "QSPI", this is support for QPI mode (4-4-4).

Could you please help us to recheck for the update? Thanks again.

kartben · 2025-08-26T12:11:51Z

include/zephyr/drivers/flash/ra_flash_api_extensions.h

+	/* Reset Flash device (at QPI(4-4-4) mode) */
+	QSPI_FLASH_EX_OP_EXIT_QPI,


this needs proper documentation, see FLASH_RA_EX_OP_WRITE_PROTECT doc in main -- even though I guess there's no in / out to document, there should still be proper doxygen documentation

I have updated it to follow proper Doxygen documentation standards, thank you

kartben · 2025-08-26T12:15:30Z

drivers/flash/flash_renesas_ra_qspi.c

+#define PAGE_SIZE_BYTE       SPI_NOR_PAGE_SIZE
+/* sector size of QSPI flash device */
+#define BLOCK_SIZE_4K        (4096U)
+#define BLOCK_SIZE_32K       (32678U)


Indeed. Please fix

kartben · 2025-08-26T12:16:07Z

drivers/flash/flash_renesas_ra_qspi.c

+	uint8_t buffer[size];
+
+	acquire_device(dev);
+	memset(&buffer[0], 0, sizeof(buffer));
+	buffer[0] = QSPI_QPI_CMD_RDSFDP;
+	buffer[1] = addr;
+	buffer[2] = addr >> 8;
+	buffer[3] = addr >> 16;
+
+	err = R_QSPI_DirectWrite(&qspi_data->qspi_ctrl, &buffer[0], FOUR_BYTE, true);
+	if (err != FSP_SUCCESS) {
+		LOG_ERR("Direct write for READ SFDP failed");
+		err = -EIO;
+		goto out;
+	}
+
+	err = R_QSPI_DirectRead(&qspi_data->qspi_ctrl, &buffer[0], size);


https://docs.zephyrproject.org/latest/contribute/coding_guidelines/index.html#:~:text=Variable%2Dlength%20array%20types%20shall%20not%20be%20used

kartben · 2025-08-26T12:17:56Z

drivers/flash/flash_renesas_ra_qspi.c

+#define QSPI_FLASH_ADDRESS(page_no)                                                                \
+	((uint8_t *)(QSPI_DEVICE_START_ADDRESS + ((page_no) * SPI_NOR_PAGE_SIZE)))


Yes, I have removed it. Many thanks

kartben · 2025-09-01T22:36:12Z

@khoa-nguyen-18 @thaoluonguw ping in case you missed my comments

Add QSPI Flash driver supports for Renesas RA6. Signed-off-by: Tri Nguyen <[email protected]> Signed-off-by: Thao Luong <[email protected]> Signed-off-by: Khoa Nguyen <[email protected]>

Add qspi node on Renesas RA6 devicetree to support QSPI flash driver Signed-off-by: Quy Tran <[email protected]>

Add support for QSPI flash driver on EK-RA6E2, EK-RA6M3, EK-RA6M4 and EK-RA6M5 Signed-off-by: Quy Tran <[email protected]> Signed-off-by: Khoa Nguyen <[email protected]>

Add support to test flash/common for qspi_nor on Renesas ek_ra6m5, ek_ra6m4, ek_ra6m3, ek_ra6e2 Signed-off-by: Khoa Nguyen <[email protected]>

Add support for qspi Renesas RA to run the sample spi_flash Signed-off-by: Khoa Nguyen <[email protected]>

Add support for qspi_nor for the sample jesd216 to run sample on Renesas RA6 boards Signed-off-by: Khoa Nguyen <[email protected]>

sonarqubecloud · 2025-09-03T06:52:33Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

thaoluonguw added the platform: Renesas RA Renesas Electronics Corporation, RA label Sep 24, 2024

zephyrbot added manifest manifest-hal_renesas DNM This PR should not be merged (Do Not Merge) labels Sep 24, 2024

soburi mentioned this pull request Oct 1, 2024

dts: renesas_ra: Changing to describe clocks with DeviceTree's standard manner #78365

Merged

thaoluonguw force-pushed the support_renesas_ra6_qspi branch from d793e21 to 96a9f25 Compare October 1, 2024 14:54

thaoluonguw marked this pull request as ready for review October 1, 2024 16:26

zephyrbot added area: Flash area: Samples Samples labels Oct 1, 2024

zephyrbot requested review from KhiemNguyenT, de-nordic, duynguyenxa, kartben, nashif and soburi October 1, 2024 16:27

zephyrbot assigned de-nordic Oct 1, 2024

soburi reviewed Oct 5, 2024

View reviewed changes

include/zephyr/drivers/flash/ra_flash_api_extensions.h Outdated Show resolved Hide resolved

thaoluonguw force-pushed the support_renesas_ra6_qspi branch from 96a9f25 to 92e6654 Compare October 11, 2024 17:22

zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Oct 11, 2024

thaoluonguw force-pushed the support_renesas_ra6_qspi branch from 92e6654 to 8187848 Compare October 11, 2024 17:50

quytranpzz approved these changes Oct 14, 2024

View reviewed changes

KhiemNguyenT added this to the v4.0.0 milestone Oct 14, 2024

KhiemNguyenT previously approved these changes Oct 14, 2024

View reviewed changes

soburi reviewed Oct 15, 2024

View reviewed changes

dts/bindings/mtd/renesas,ra-qspi-nor.yaml Outdated Show resolved Hide resolved

de-nordic requested changes Oct 15, 2024

View reviewed changes

thaoluonguw dismissed KhiemNguyenT’s stale review via f462ce1 October 18, 2024 11:23

thaoluonguw force-pushed the support_renesas_ra6_qspi branch from 8187848 to f462ce1 Compare October 18, 2024 11:23

kartben requested changes Aug 26, 2025

View reviewed changes

kartben assigned soburi and KhiemNguyenT and unassigned de-nordic Aug 26, 2025

khoa-nguyen-18 dismissed stale reviews from soburi, pillo79, facchinm, thenguyenyf, and duynguyenxa via a406f3e September 3, 2025 05:18

khoa-nguyen-18 force-pushed the support_renesas_ra6_qspi branch from 012bb7f to a406f3e Compare September 3, 2025 05:18

Tri Nguyen and others added 6 commits September 3, 2025 06:26

drivers: flash: Initial support QSPI Flash driver for Renesas RA6

5cac4bd

Add QSPI Flash driver supports for Renesas RA6. Signed-off-by: Tri Nguyen <[email protected]> Signed-off-by: Thao Luong <[email protected]> Signed-off-by: Khoa Nguyen <[email protected]>

dts: renesas: Add devicetree property for QSPI support on RA6

b730963

Add qspi node on Renesas RA6 devicetree to support QSPI flash driver Signed-off-by: Quy Tran <[email protected]>

boards: renesas: Add boards support for QSPI flash driver

0a8e582

Add support for QSPI flash driver on EK-RA6E2, EK-RA6M3, EK-RA6M4 and EK-RA6M5 Signed-off-by: Quy Tran <[email protected]> Signed-off-by: Khoa Nguyen <[email protected]>

tests: drivers: flash: Add support to test qspi_nor for RA6

9fde081

Add support to test flash/common for qspi_nor on Renesas ek_ra6m5, ek_ra6m4, ek_ra6m3, ek_ra6e2 Signed-off-by: Khoa Nguyen <[email protected]>

samples: drivers: spi_flash: add support for qspi Renesas RA

ae6a59a

Add support for qspi Renesas RA to run the sample spi_flash Signed-off-by: Khoa Nguyen <[email protected]>

samples: drivers: jesd216: Add support for qspi_nor for RA

04e7722

Add support for qspi_nor for the sample jesd216 to run sample on Renesas RA6 boards Signed-off-by: Khoa Nguyen <[email protected]>

khoa-nguyen-18 force-pushed the support_renesas_ra6_qspi branch from a406f3e to 04e7722 Compare September 3, 2025 06:27

khoa-nguyen-18 requested review from duynguyenxa, facchinm, kartben, pillo79, soburi and thenguyenyf September 4, 2025 01:36

thenguyenyf approved these changes Sep 4, 2025

View reviewed changes

soburi approved these changes Sep 4, 2025

View reviewed changes

de-nordic approved these changes Sep 5, 2025

View reviewed changes

kartben approved these changes Sep 5, 2025

View reviewed changes

henrikbrixandersen merged commit 9a7a2b0 into zephyrproject-rtos:main Sep 5, 2025
27 checks passed

	/*
	* Extended operation interface provides flexible way for supporting flash
	* controller features. Code space is divided equally into Zephyr codes
	* (MSb == 0) and vendor codes (MSb == 1). This way we can easily add extended
	* operations to the drivers without cluttering the API or problems with API
	* incompatibility. Extended operation can be promoted from vendor codes to
	* Zephyr codes if the feature is available in most flash controllers and
	* can be represented in the same way.
	*
	* It's not forbidden to have operation in Zephyr codes and vendor codes for
	* the same functionality. In this case, vendor operation could provide more
	* specific access when abstraction in Zephyr counterpart is insufficient.
	*/
	#define FLASH_EX_OP_VENDOR_BASE 0x8000
	#define FLASH_EX_OP_IS_VENDOR(c) ((c) & FLASH_EX_OP_VENDOR_BASE)

		/* Reset Flash device (at QPI(4-4-4) mode) */
		QSPI_FLASH_EX_OP_EXIT_QPI,

		#define QSPI_FLASH_ADDRESS(page_no) \
		((uint8_t )(QSPI_DEVICE_START_ADDRESS + ((page_no) SPI_NOR_PAGE_SIZE)))

Support QSPI Flash driver for Renesas RA6 devices #78959

Support QSPI Flash driver for Renesas RA6 devices #78959

Uh oh!

Conversation

thaoluonguw commented Sep 24, 2024

Uh oh!

zephyrbot commented Sep 24, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

de-nordic left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

de-nordic commented Oct 15, 2024

Uh oh!

thaoluonguw commented Oct 21, 2024

Uh oh!

kartben Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kartben Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kartben commented Sep 1, 2025

Uh oh!

sonarqubecloud bot commented Sep 3, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

zephyrbot commented Sep 24, 2024 •

edited by github-actions bot

Loading

kartben Aug 26, 2025 •

edited

Loading

kartben Aug 26, 2025 •

edited

Loading