Skip to content

usb: device_next: USB CDC NCM class implementation #79508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nashif merged 4 commits into from
Oct 17, 2024
Merged

usb: device_next: USB CDC NCM class implementation #79508

nashif merged 4 commits into from
Oct 17, 2024

Conversation

@jukkar
Copy link
Member

@jukkar jukkar commented Oct 7, 2024 •
edited
Loading

This implements USB Network Control Model (NCM) driver for the USB next stack.

Following things are not implemented (yet):

  • ntb32 format support
  • Sending more than 1 Ethernet frames / USB packet to host. Note that it is possible to receive more than one Ethernet frames / USB packet to device.

How to try this:

west build -p -b nrf5340dk/nrf5340/cpuapp -d ../build/usb-next-zperf samples/net/zperf/ -- \
-DEXTRA_DTC_OVERLAY_FILE="usbd_next_ncm.overlay" \
-DOVERLAY_CONFIG="overlay-usbd_next.conf" \
-DCONFIG_NET_SHELL=y -DCONFIG_NET_LOG=y \
-DCONFIG_NET_L2_ETHERNET=y \
-DCONFIG_USB_DEVICE_STACK_NEXT=y \
-DCONFIG_USBD_SHELL=y \
-DCONFIG_USBD_CDC_NCM_LOG_LEVEL_DBG=n \
-DCONFIG_NET_IF_LOG_LEVEL_DBG=n

@jukkar jukkar requested a review from jfischer-no October 7, 2024 14:41
@jukkar jukkar force-pushed the devel/usb-ncm branch 2 times, most recently from f299a12 to d1efbbf Compare October 9, 2024 06:33
@jukkar
Copy link
Member Author

jukkar commented Oct 9, 2024

  • CI fixes

@jukkar jukkar marked this pull request as ready for review October 9, 2024 12:41
rlubos
rlubos previously approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@rlubos rlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Net part looks ok.

@jukkar jukkar mentioned this pull request Oct 10, 2024
Closed
57 tasks
jfischer-no
jfischer-no reviewed Oct 15, 2024
View reviewed changes
@jfischer-no jfischer-no changed the title USB next NCM driver usb: device_next: USB CDC NCM class implementation Oct 15, 2024
@jfischer-no jfischer-no assigned jfischer-no and unassigned kartben Oct 15, 2024
@jukkar
Copy link
Member Author

jukkar commented Oct 15, 2024

  • Updated according to comments
  • Rebased against latest main

jfischer-no
jfischer-no reviewed Oct 15, 2024
View reviewed changes
@jukkar
Copy link
Member Author

jukkar commented Oct 15, 2024

  • Updated according to comments

jfischer-no
jfischer-no reviewed Oct 16, 2024
View reviewed changes
@jukkar jukkar force-pushed the devel/usb-ncm branch 2 times, most recently from 48cc675 to 03e8979 Compare October 16, 2024 12:55
@jukkar
Copy link
Member Author

jukkar commented Oct 16, 2024

  • reworked and simplified the sending side
  • updated to latest main

@jukkar
Copy link
Member Author

jukkar commented Oct 16, 2024

  • removed extra unused variable from cdc_ncm_acl_out_cb()

jfischer-no
jfischer-no previously approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@jfischer-no jfischer-no left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@jfischer-no jfischer-no added this to the v4.0.0 milestone Oct 16, 2024
@jukkar jukkar requested a review from rlubos October 16, 2024 14:26
jukkar added 4 commits October 17, 2024 13:21
@jukkar
usb: device_next: NCM driver for usb-next
1d6325d 
USB NCM Ethernet driver implementation.

Signed-off-by: Jukka Rissanen <[email protected]>
@jukkar
samples: usb: common: Add NCM when setting code triple
2a08df2 
Add NCM class to sample usbd initialization and the code
triple is set properly.

Signed-off-by: Jukka Rissanen <[email protected]>
@jukkar
samples: net: zperf: Add USB CDC NCM support
3ded076 
Add support for USB cdc_ncm to zperf application.

Signed-off-by: Jukka Rissanen <[email protected]>
@jukkar
samples: net: echo-server: Add USB CDC NCM support
b72de89 
Add support for USB cdc_ncm to echo-server application.

Signed-off-by: Jukka Rissanen <[email protected]>
@jukkar
Copy link
Member Author

jukkar commented Oct 17, 2024

  • resolving merge conflict

@nashif nashif merged commit 4c0a72b into zephyrproject-rtos:main Oct 17, 2024
@jukkar jukkar deleted the devel/usb-ncm branch October 18, 2024 05:57
@josuah josuah mentioned this pull request Oct 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfischer-no jfischer-no jfischer-no approved these changes

@rlubos rlubos rlubos approved these changes

@decsny decsny Awaiting requested review from decsny

@galak galak Awaiting requested review from galak

@kartben kartben Awaiting requested review from kartben

@lmajewski lmajewski Awaiting requested review from lmajewski

@nashif nashif Awaiting requested review from nashif

@pdgendt pdgendt Awaiting requested review from pdgendt

@ssharks ssharks Awaiting requested review from ssharks

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

@tmon-nordic tmon-nordic Awaiting requested review from tmon-nordic

Assignees

@jfischer-no jfischer-no

Labels

area: Devicetree area: Ethernet area: Networking area: Samples Samples area: Sockets Networking sockets area: USB Universal Serial Bus

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@jukkar @jfischer-no @rlubos @kartben @nashif @zephyrbot