Skip to content

Conversation

@MaochenWang1
Copy link
Contributor

Update hal_nxp to add Wi-Fi driver code.

@zephyrbot zephyrbot added the size: XS A PR changing only a single line of code label Oct 8, 2024
@zephyrbot
Copy link

zephyrbot commented Oct 8, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@683c007 zephyrproject-rtos/hal_nxp@99570ee (master) zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Oct 8, 2024
@dleach02 dleach02 self-assigned this Oct 8, 2024
@bjarki-andreasen bjarki-andreasen dismissed their stale review October 8, 2024 15:44

sorry, bit to quick :)

@bjarki-andreasen
Copy link
Contributor

looks good, ping when its a sha :)

@MaochenWang1 MaochenWang1 force-pushed the main_mc_update_hal_nxp_416 branch from e5787e5 to 8666a0b Compare October 18, 2024 06:46
@dleach02 dleach02 force-pushed the main_mc_update_hal_nxp_416 branch 2 times, most recently from f45f3e2 to a72fb7f Compare October 18, 2024 19:06
dleach02
dleach02 previously approved these changes Oct 18, 2024
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Oct 18, 2024
@dleach02 dleach02 added this to the v4.0.0 milestone Oct 18, 2024
danieldegrasse
danieldegrasse previously approved these changes Oct 18, 2024
@danieldegrasse danieldegrasse dismissed their stale review October 18, 2024 19:42

Too quick, still discussing this internally

@danieldegrasse danieldegrasse force-pushed the main_mc_update_hal_nxp_416 branch from a72fb7f to beffd8e Compare October 18, 2024 22:15
@dleach02 dleach02 force-pushed the main_mc_update_hal_nxp_416 branch from 445b8b6 to 39c2e10 Compare October 23, 2024 17:21
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Oct 23, 2024
@dleach02
Copy link
Member

@bjarki-andreasen it is a sha

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bool "Build only mode (do not link wireless binary blob)"
bool "Build only mode (do not link wireless firmware blob)"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks

krish2718
krish2718 previously approved these changes Oct 23, 2024
@dleach02
Copy link
Member

CI failure is with a new test that merged between last night and resubmission of the PR with a SHA. Working to fix it now :-(

MaochenWang1 and others added 10 commits October 23, 2024 17:00
Update hal_nxp to add Wi-Fi driver code.

Signed-off-by: Maochen Wang <[email protected]>
ap_bandwidth API implementation is not complete. Remove the structure
definition and implementation from the NXP WiFi driver to fix a build
error.

Signed-off-by: Daniel DeGrasse <[email protected]>
set_btwt API implementation is not complete. Remove the structure
definition and implementation from the NXP WiFi driver to fix a build
error.

Signed-off-by: Daniel DeGrasse <[email protected]>
Remove references to TWT fields that did not exist, to resolve a build
error.

Signed-off-by: Daniel DeGrasse <[email protected]>
Remove unused function `nxp_wifi_uap_status`.

Signed-off-by: Daniel DeGrasse <[email protected]>
Add CONFIG_NXP_WIFI_BUILD_ONLY_MODE, which allows the NXP WiFi driver to
be built without a binary blob. The built application will not be
functional, but this enables continuous integration to run upstream.

Signed-off-by: Daniel DeGrasse <[email protected]>
Fix build error of multiple definition of `dh5_init' in
crypto_mbedtls_alt.c when WPS enabled.

Signed-off-by: Maochen Wang <[email protected]>
Remove CONFIG_MBEDTLS_HAVE_TIME_DATE, which will cause that mbedtls
include Zephyr time.h and leads to 'DIV_ROUND_UP' redefined warning.

Signed-off-by: Maochen Wang <[email protected]>
Generated PEM headers need to be created before we build the WiFi shell
when WIFI_NM_WPA_SUPPLICANT_CRYPTO_ENTERPRISE is enabled, so add an
explicit dependency on the app target to be certain these headers are
created

Signed-off-by: Daniel DeGrasse <[email protected]>
Add support for building NXP WiFi. Since the driver typically requires
binary blobs, enable CONFIG_NXP_WIFI_BUILD_ONLY_MODE for this testcase.

Signed-off-by: Daniel DeGrasse <[email protected]>
@danieldegrasse danieldegrasse force-pushed the main_mc_update_hal_nxp_416 branch from 39c2e10 to 4f53c6b Compare October 23, 2024 22:27
@MaochenWang1
Copy link
Contributor Author

Hi @krish2718 @bjarki-andreasen pls review again

@henrikbrixandersen henrikbrixandersen merged commit a3d2b86 into zephyrproject-rtos:main Oct 24, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Networking area: Samples Samples area: Wi-Fi Wi-Fi manifest manifest-hal_nxp platform: NXP Drivers NXP Semiconductors, drivers size: XS A PR changing only a single line of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants