subsys: ipc: icbmsg: Reduce block alignment to 32-bits #79604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: IPC
zephyrbot
requested review from
anangl,
arnopo,
carlocaione,
decsny,
galak,
jaz1-nordic,
kartben,
kl-cruz,
magp-nordic,
masz-nordic,
nashif and
nika-nordic
doki-nordic
force-pushed
the
lower-icbmsg-block-align
branch
from
e8d0227 to
d34d8cf
Compare
doki-nordic
force-pushed
the
lower-icbmsg-block-align
branch
from
d34d8cf to
1c409ca
Compare
dchat-nordic
approved these changes
Oct 17, 2024
doki-nordic
force-pushed
the
lower-icbmsg-block-align
branch
from
1c409ca to
73fd121
Compare
anangl
previously approved these changes
Oct 23, 2024
doki-nordic
added a commit
to doki-nordic/sdk-zephyr
that referenced
this pull request
Oct 23, 2024
The ICBMsg backend divides its memory into blocks. Each block is aligned to data cache alignment. Is it not required, since adjacent blocks has the same data flow direction (either read-only or write-only). This commit changes it to 32-bits making wasted memory significantly reduced. Upstream PR: zephyrproject-rtos/zephyr#79604 Signed-off-by: Dominik Kilian <[email protected]>
The ICBMsg backend divides its memory into blocks. Each block is aligned to data cache alignment. Is it not required, since adjacent blocks has the same data flow direction (either read-only or write-only). This commit changes it to 32-bits making wasted memory significantly reduced. Signed-off-by: Dominik Kilian <[email protected]>
doki-nordic
force-pushed
the
lower-icbmsg-block-align
branch
from
73fd121 to
b293e41
Compare
anangl
approved these changes
Oct 24, 2024
de-nordic
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ICBMsg backend divides its memory into blocks. Each block is aligned to data cache alignment. Is it not required, since adjacent blocks has the same data flow direction (either read-only or write-only). This commit changes it to 32-bits making wasted memory significantly reduced.