Comparator: Add gpio_loopback based test suite #79724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjarki-andreasen
requested review from
anangl,
fabiobaltieri,
henrikbrixandersen,
kartben and
nordic-piks
bjarki-andreasen
force-pushed
the
comp-gpio-test-suite
branch
2 times, most recently
from
0d8cb8c to
01642d3
Compare
nordic-piks
reviewed
Oct 16, 2024
nordic-piks
reviewed
Oct 16, 2024
bjarki-andreasen
force-pushed
the
comp-gpio-test-suite
branch
2 times, most recently
from
77d087c to
90231fd
Compare
nordic-piks
approved these changes
Oct 17, 2024
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 17, 2024
Add test suite which uses GPIO loopback to produce a "very low" and "very high" voltage at the positive input of the comparator using the output of a GPIO. The negative input is set to a voltage between the high and low output voltages of the GPIO using whichever internal reference is available to the comparator. Upstream PR: zephyrproject-rtos/zephyr#79724 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
fabiobaltieri
previously approved these changes
Oct 17, 2024
Add test suite which uses GPIO loopback to produce a "very low" and "very high" voltage at the positive input of the comparator using the output of a GPIO. The negative input is set to a voltage between the high and low output voltages of the GPIO using whichever internal reference is available to the comparator. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
force-pushed
the
comp-gpio-test-suite
branch
from
90231fd to
e890330
Compare
Contributor
Author
|
forgot to remove the last PDK file :) |
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 18, 2024
Add test suite which uses GPIO loopback to produce a "very low" and "very high" voltage at the positive input of the comparator using the output of a GPIO. The negative input is set to a voltage between the high and low output voltages of the GPIO using whichever internal reference is available to the comparator. Upstream PR: zephyrproject-rtos/zephyr#79724 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
fabiobaltieri
approved these changes
Oct 18, 2024
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 21, 2024
Add test suite which uses GPIO loopback to produce a "very low" and "very high" voltage at the positive input of the comparator using the output of a GPIO. The negative input is set to a voltage between the high and low output voltages of the GPIO using whichever internal reference is available to the comparator. Upstream PR: zephyrproject-rtos/zephyr#79724 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
bjarki-andreasen
added a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Oct 21, 2024
Add test suite which uses GPIO loopback to produce a "very low" and "very high" voltage at the positive input of the comparator using the output of a GPIO. The negative input is set to a voltage between the high and low output voltages of the GPIO using whichever internal reference is available to the comparator. Upstream PR: zephyrproject-rtos/zephyr#79724 Signed-off-by: Bjarki Arge Andreasen <[email protected]>
Member
|
Wouldn't it be better to use a DAC output? |
Contributor
Author
It would be cool :) but it would require fixtures with two DACs and loop back to the differential comparator inputs, which is not exactly common :) I went with this simpler GPIO loopback based one to be as portable as possible :) |
henrikbrixandersen
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test suite which uses GPIO loopback to produce a "very low" and "very high" voltage at the positive input of the comparator using the output of a GPIO. The negative input is set to a voltage between the high and low output voltages of the GPIO using whichever internal reference is available to the comparator.