wifi: nrf70: Fix reg memleak #79891
Merged
wifi: nrf70: Fix reg memleak #79891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_nordic
DNM
jukkar
previously approved these changes
Oct 16, 2024
rlubos
previously approved these changes
Oct 16, 2024
sachinthegreen
previously approved these changes
Oct 16, 2024
krish2718
dismissed stale reviews from sachinthegreen, rlubos, and jukkar
via
4dbf476
krish2718
force-pushed
the
fix_reg_memleak
branch
from
4f0303e to
4dbf476
Compare
rlubos
previously approved these changes
Oct 16, 2024
krish2718
force-pushed
the
fix_reg_memleak
branch
from
4dbf476 to
0dda303
Compare
sachinthegreen
previously approved these changes
Oct 17, 2024
krish2718
force-pushed
the
fix_reg_memleak
branch
from
0dda303 to
bf74b11
Compare
sachinthegreen
previously approved these changes
Oct 17, 2024
jukkar
previously approved these changes
Oct 18, 2024
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 18, 2024
This log helps in identifing if the event is solicited or not. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 18, 2024
…cited reg event This flag can be used to drop unsolicited regulatory event as it's not supported. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 18, 2024
During Wi-Fi connection UMAC sends an unsolicited regulatory change event but the driver code always assumes that this event is solicited hence doesn't free the memory for the event. Fix this by dropping the unsolicited event as it's not supported yet. Fixes #79733. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 18, 2024
Fix couple of bugs in exit path: - In case of calloc failure, return's without unlocking - memory is freed outside lock, in case of a tiny window of race, this can cause a crash when this function is called from two threads. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 21, 2024
Opriv was removed but the doxygen doc string was left. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 21, 2024
This log helps in identifing if the event is solicited or not. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 21, 2024
During Wi-Fi connection UMAC sends an unsolicited regulatory change event but the driver code always assumes that this event is solicited hence doesn't free the memory for the event. Fix this by dropping the unsolicited event as it's not supported yet. Fixes #79733. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 21, 2024
Fix couple of bugs in exit path: - In case of calloc failure, return's without unlocking - memory is freed outside lock, in case of a tiny window of race, this can cause a crash when this function is called from two threads. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 21, 2024
Opriv was removed but the doxygen doc string was left. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 21, 2024
This log helps in identifing if the event is solicited or not. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 21, 2024
During Wi-Fi connection UMAC sends an unsolicited regulatory change event but the driver code always assumes that this event is solicited hence doesn't free the memory for the event. Fix this by dropping the unsolicited event as it's not supported yet. Fixes #79733. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 21, 2024
Fix couple of bugs in exit path: - In case of calloc failure, return's without unlocking - memory is freed outside lock, in case of a tiny window of race, this can cause a crash when this function is called from two threads. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 21, 2024
Opriv was removed but the doxygen doc string was left. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 21, 2024
This log helps in identifing if the event is solicited or not. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 21, 2024
During Wi-Fi connection UMAC sends an unsolicited regulatory change event but the driver code always assumes that this event is solicited hence doesn't free the memory for the event. Fix this by dropping the unsolicited event as it's not supported yet. Fixes #79733. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 21, 2024
Fix couple of bugs in exit path: - In case of calloc failure, return's without unlocking - memory is freed outside lock, in case of a tiny window of race, this can cause a crash when this function is called from two threads. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 21, 2024
Opriv was removed but the doxygen doc string was left. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
This log helps in identifing if the event is solicited or not. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
During Wi-Fi connection UMAC sends an unsolicited regulatory change event but the driver code always assumes that this event is solicited hence doesn't free the memory for the event. Fix this by dropping the unsolicited event as it's not supported yet. Fixes #79733. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
Fix couple of bugs in exit path: - In case of calloc failure, return's without unlocking - memory is freed outside lock, in case of a tiny window of race, this can cause a crash when this function is called from two threads. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
Opriv was removed but the doxygen doc string was left. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
This log helps in identifing if the event is solicited or not. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
During Wi-Fi connection UMAC sends an unsolicited regulatory change event but the driver code always assumes that this event is solicited hence doesn't free the memory for the event. Fix this by dropping the unsolicited event as it's not supported yet. Fixes #79733. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
Fix couple of bugs in exit path: - In case of calloc failure, return's without unlocking - memory is freed outside lock, in case of a tiny window of race, this can cause a crash when this function is called from two threads. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
Opriv was removed but the doxygen doc string was left. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
This log helps in identifing if the event is solicited or not. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
During Wi-Fi connection UMAC sends an unsolicited regulatory change event but the driver code always assumes that this event is solicited hence doesn't free the memory for the event. Fix this by dropping the unsolicited event as it's not supported yet. Fixes #79733. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
Fix couple of bugs in exit path: - In case of calloc failure, return's without unlocking - memory is freed outside lock, in case of a tiny window of race, this can cause a crash when this function is called from two threads. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
Opriv was removed but the doxygen doc string was left. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
This log helps in identifing if the event is solicited or not. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
During Wi-Fi connection UMAC sends an unsolicited regulatory change event but the driver code always assumes that this event is solicited hence doesn't free the memory for the event. Fix this by dropping the unsolicited event as it's not supported yet. Fixes #79733. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
Fix couple of bugs in exit path: - In case of calloc failure, return's without unlocking - memory is freed outside lock, in case of a tiny window of race, this can cause a crash when this function is called from two threads. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
added a commit
to krish2718/sdk-zephyr
that referenced
this pull request
Oct 22, 2024
Opriv was removed but the doxygen doc string was left. Upstream PR: zephyrproject-rtos/zephyr#79891 Signed-off-by: Chaitanya Tata <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a memory leak in regulatory domain handling.