sample/testcase.yaml: replace deprecated OVERLAY_CONFIG with EXTRA_CONF_FILE #80083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarmouniA
added
area: Samples
thedjnK
requested changes
Oct 18, 2024
Contributor
thedjnK
left a comment
thedjnK
left a comment
There was a problem hiding this comment.
I really do not see the value in any of these renames
JarmouniA
force-pushed
the
fix_overlay_config_use
branch
2 times, most recently
from
fe63339 to
922a83e
Compare
JarmouniA
changed the title
thedjnK
previously approved these changes
Oct 19, 2024
zephyrbot
requested review from
Casper-Bonde-Bose,
MariuszSkamra,
Thalley,
asbjornsabo,
fredrikdanebjer,
jhedberg,
kartben,
kruithofa,
larsgk,
nashif,
niym-ot,
pin-zephyr and
sjanc
butok
previously approved these changes
Oct 22, 2024
kartben
previously approved these changes
Oct 22, 2024
Move stm32_blk.conf ouside of 'boards' as this folder is meant to contain only board-specific devicetree overlays and Kconfig fragments. Signed-off-by: Abderrahmane Jarmouni <[email protected]>
…_FILE Replace some OVERLAY_CONFIG that were missed in a pervious PR. Signed-off-by: Abderrahmane Jarmouni <[email protected]>
Replace OVERLAY_CONFIG with CONF_FILE since the file in question contains an alternative configuration to the one in prj.conf as clearly stated in the sample doc 'If you use poll you should also use `prj_poll.conf` instead of `prj.conf`.' Signed-off-by: Abderrahmane Jarmouni <[email protected]>
…_FILE Replace some OVERLAY_CONFIG that were missed in a pervious PR. Signed-off-by: Abderrahmane Jarmouni <[email protected]>
Replace OVERLAY_CONFIG with CONF_FILE since no-device-pm.conf contains an alternative configuration to the one in prj.conf Signed-off-by: Abderrahmane Jarmouni <[email protected]>
JarmouniA
force-pushed
the
fix_overlay_config_use
branch
from
922a83e to
b6383dd
Compare
Contributor
Author
|
Rebased to resolve merge conflicts |
butok
approved these changes
Oct 23, 2024
jhedberg
approved these changes
Oct 23, 2024
thedjnK
approved these changes
Oct 23, 2024
kartben
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace some
OVERLAY_CONFIGinstances that were missed in #79504.Also, fix incorrect use of
EXTRA_CONF_FILE, instead ofCONF_FILE, when the config file actually contains an alternative config & not just additional/modified options.