bluetooth: shell: Fix includes #80105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
carlescufi,
cvinayak,
erbr-ot,
kruithofa,
mtpr-ot,
thoh-ot and
wopu-ot
cvinayak
requested changes
Oct 21, 2024
Contributor
There was a problem hiding this comment.
Question:
* For those two settings, would it be okay (tolerated? appreciated?) to add an an extra build in CI "just" to test whether enabling those flags does not break the build?
Please add a new tests target in testcases.yaml file with added extra_configs with CONFIG_BT_CTLR_DTM for nrf52840dk/nrf52840 board.
Using which board did you discover the issue?
cvinayak
added
bug
Contributor
Author
An nRF52840 (or maybe nRF54L15) based out-of-tree board. |
Contributor
Author
Any proposal on which Or did you mean to add a directory |
Contributor
|
Contributor
|
@rettichschnidi is this something you will be able to follow up soon before the Zephyr v4.0 feature freeze or create GH issue to fix it in bug fix phase? |
Contributor
Author
I'll take care of it today. I am a bit confused however due to your proposed changes - they essentially revert some of my patch. Need to investigate, likely an overlook on my end. |
This allows to build the shell with BT_CTLR_DTM and/or BT_CTLR_ADV_EXT enabled. The issues has been introduced by commit bf897cf (Bluetooth: Shell: Restructure shell files). Signed-off-by: Reto Schneider <[email protected]>
This ensures that enabling BT_CTLR_DTM does not break the compilation of the Bluetooth shell. Signed-off-by: Reto Schneider <[email protected]>
rettichschnidi
force-pushed
the
gardena/rs/upstream/fix-ble-controller-shell-include
branch
from
9589e37 to
cf974e2
Compare
zephyrbot
requested review from
alwa-nordic,
hermabe,
jhedberg,
rugeGerritsen and
sjanc
thedjnK
approved these changes
Oct 25, 2024
cvinayak
approved these changes
Oct 26, 2024
rettichschnidi
deleted the
gardena/rs/upstream/fix-ble-controller-shell-include
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to build the shell with BT_CTLR_DTM and/or BT_CTLR_ADV_EXT enabled.
The issues has been introduced by commit
bf897cf (Bluetooth: Shell: Restructure shell files).
Question: