Skip to content

Conversation

@gangli02
Copy link
Contributor

@gangli02 gangli02 commented Oct 22, 2024

Fixed build error, when disabling 802.11ax, if-else does not match.
Fixes #81117

@zephyrbot zephyrbot added platform: NXP Drivers NXP Semiconductors, drivers area: Wi-Fi Wi-Fi labels Oct 22, 2024
@gangli02 gangli02 changed the title drivers: wifi: nxp: Fix macro wrapping error drivers: wifi: nxp: fix macro wrapping error Oct 22, 2024
@gangli02 gangli02 force-pushed the main_driver_11ax branch 2 times, most recently from 314b2b2 to 4a3d3b7 Compare October 24, 2024 06:00
jukkar
jukkar previously approved these changes Oct 24, 2024
decsny
decsny previously approved these changes Nov 4, 2024
@danieldegrasse
Copy link
Contributor

@gangli02 A few requests- I am assuming this PR fixes a bug based on the description

  • Please make the commit message more specific. Is this fixing a build error? A runtime error? It is not clear based on the message here
  • Please submit a new issue to Zephyr (following the bug report template given when creating one) that describes the issue this PR fixes. Then add Fixes #xxxx (where xxxx is the issue number, visible in the URL of the issue) to the bottom of the commit message, directly above the signed-off-by-line

@gangli02
Copy link
Contributor Author

gangli02 commented Nov 6, 2024

@gangli02 A few requests- I am assuming this PR fixes a bug based on the description

  • Please make the commit message more specific. Is this fixing a build error? A runtime error? It is not clear based on the message here
  • Please submit a new issue to Zephyr (following the bug report template given when creating one) that describes the issue this PR fixes. Then add Fixes #xxxx (where xxxx is the issue number, visible in the URL of the issue) to the bottom of the commit message, directly above the signed-off-by-line

OK, I will update.

@mmahadevan108
Copy link
Contributor

Please add a Zephyr Issue describing the problem seen and link it to this PR. That way we can include this change into the upcoming 4.0 release.

@gangli02 gangli02 dismissed stale reviews from decsny and jukkar via a167ef4 November 8, 2024 08:09
@gangli02 gangli02 changed the title drivers: wifi: nxp: fix macro wrapping error drivers: wifi: nxp: fix build failure after disabling 802.11ax Nov 8, 2024
@gangli02 gangli02 force-pushed the main_driver_11ax branch 2 times, most recently from 3136df1 to 4e8d61b Compare November 8, 2024 08:50
Fixed build error, when disabling 802.11ax, if-else does not match.
Fixes zephyrproject-rtos#81117

Signed-off-by: Gang Li <[email protected]>
@gangli02
Copy link
Contributor Author

gangli02 commented Nov 8, 2024

Please add a Zephyr Issue describing the problem seen and link it to this PR. That way we can include this change into the upcoming 4.0 release.

OK, this is the issue raised: #81117

@nashif nashif merged commit f8acf35 into zephyrproject-rtos:main Nov 16, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Wi-Fi Wi-Fi platform: NXP Drivers NXP Semiconductors, drivers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rd_rw612_bga/frdm_rw612: wifi: shell: Failing to build with disable 802.11ax

7 participants