Skip to content

Conversation

@khoa-nguyen-18
Copy link
Contributor

@khoa-nguyen-18 khoa-nguyen-18 commented Oct 22, 2024

  • Modify the macro that is used in source code AGT to get the right data from the device tree
  • Modify the name of agt node in RA8 device tree
  • Modify the name of the prescaler property of RA8 in samples/drivers/counter/alarm/
    Bug PR: Add Counter driver support for Renesas RA8 board #76141

- Modify the macro in source code AGT to get the right data from
device tree
- Modify name of agt node

Signed-off-by: Khoa Nguyen <[email protected]>
@khoa-nguyen-18 khoa-nguyen-18 marked this pull request as ready for review October 23, 2024 01:08
@zephyrbot zephyrbot added platform: Renesas RA Renesas Electronics Corporation, RA area: Samples Samples area: Counter labels Oct 23, 2024
@kartben kartben removed their request for review October 23, 2024 01:11
@duynguyenxa duynguyenxa added the bug The issue is a bug, or the PR is fixing a bug label Oct 23, 2024
@khoa-nguyen-18
Copy link
Contributor Author

@nordic-krch @nashif Could you please take a look?

Copy link
Contributor

@dkalowsk dkalowsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason not to include this in RC2?

@dkalowsk dkalowsk added this to the v4.0.0 milestone Oct 28, 2024
@mmahadevan108 mmahadevan108 merged commit b56d6e6 into zephyrproject-rtos:main Oct 29, 2024
34 checks passed
@github-actions
Copy link

Hi @khoa-nguyen-18!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

@khoa-nguyen-18 khoa-nguyen-18 deleted the fix_renesas_agt_properties branch November 6, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Counter area: Samples Samples bug The issue is a bug, or the PR is fixing a bug platform: Renesas RA Renesas Electronics Corporation, RA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants