Skip to content

drivers: nrfwifi: Fix offloaded raw tx apis #80328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nashif merged 2 commits into from
Nov 18, 2024
Merged

drivers: nrfwifi: Fix offloaded raw tx apis #80328

nashif merged 2 commits into from
Nov 18, 2024

Conversation

@kapbh
Copy link
Contributor

@kapbh kapbh commented Oct 23, 2024 •
edited by krish2718
Loading

Add and remove Kconfig in cmake.
Add changes to fix regularity domain of offloaded raw tx.

Fixes #80809

@zephyrbot zephyrbot added the area: Wi-Fi Wi-Fi label Oct 23, 2024
@zephyrbot
Copy link

zephyrbot commented Oct 23, 2024 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_nordic DNM This PR should not be merged (Do Not Merge) labels Oct 23, 2024
sachinthegreen
sachinthegreen previously approved these changes Oct 24, 2024
View reviewed changes
@krish2718 krish2718 changed the title drivers: wifi: Fix offloaded raw tx apis drivers: nrfwifi: Fix offloaded raw tx apis Oct 28, 2024
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Oct 28, 2024
sachinthegreen
sachinthegreen previously approved these changes Oct 28, 2024
View reviewed changes
krish2718
krish2718 previously approved these changes Oct 28, 2024
View reviewed changes
@dkalowsk
Copy link
Contributor

dkalowsk commented Oct 29, 2024

@jukkar is this needed for 4.0?

@krish2718
Copy link
Contributor

krish2718 commented Oct 30, 2024

@jukkar is this needed for 4.0?

It is a bug fix to get that feature (offloaded raw tx) working, so, yes.

@dkalowsk
Copy link
Contributor

dkalowsk commented Nov 4, 2024

@jukkar is this needed for 4.0?

It is a bug fix to get that feature (offloaded raw tx) working, so, yes.

okay if that is the case, @krish2718 it's going to need an Issue/Bug number attached to it now as we're at RC2 and later.

@krish2718
Copy link
Contributor

krish2718 commented Nov 4, 2024

@jukkar is this needed for 4.0?

It is a bug fix to get that feature (offloaded raw tx) working, so, yes.

okay if that is the case, @krish2718 it's going to need an Issue/Bug number attached to it now as we're at RC2 and later.

Updated description with bug reference, thanks.

jukkar
jukkar previously approved these changes Nov 5, 2024
View reviewed changes
@krish2718 krish2718 dismissed stale reviews from jukkar, sachinthegreen, and themself via 1f7d818 November 5, 2024 12:32
@krish2718 krish2718 force-pushed the cmake_fix branch 2 times, most recently from 1f7d818 to e193aaa Compare November 5, 2024 12:43
jukkar
jukkar previously approved these changes Nov 6, 2024
View reviewed changes
sachinthegreen
sachinthegreen previously approved these changes Nov 13, 2024
View reviewed changes
kapbh and others added 2 commits November 14, 2024 13:58
@kapbh
drivers: wifi: Fix offloaded raw TX feature flags
6e8627f 
Pass passive scan and offloaded raw tx feature flags to OSAL.

Signed-off-by: Kapil Bhatt <[email protected]>
@krish2718 @kapbh
drivers: nrfwifi: Remove passing unused flag
25efb80 
This flag is now unused in OSAL as it takes the input via the API.

Signed-off-by: Chaitanya Tata <[email protected]>
@nashif nashif merged commit f537cf3 into zephyrproject-rtos:main Nov 18, 2024
26 checks passed
@zephyrbot zephyrbot mentioned this pull request Nov 18, 2024
Merged
@kapbh kapbh deleted the cmake_fix branch November 18, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jukkar jukkar jukkar approved these changes

@dkalowsk dkalowsk dkalowsk approved these changes

@krish2718 krish2718 krish2718 approved these changes

@sachinthegreen sachinthegreen sachinthegreen approved these changes

@Kludentwo Kludentwo Awaiting requested review from Kludentwo

@rlubos rlubos Awaiting requested review from rlubos

Assignees

@jukkar jukkar

Labels

area: Wi-Fi Wi-Fi

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

drivers: nrfwifi: Offloaded Raw TX feature broken

7 participants

@kapbh @zephyrbot @dkalowsk @krish2718 @jukkar @sachinthegreen @nashif