Skip to content

Conversation

@rruuaanng
Copy link
Contributor

Add 'DT_HAS_ALIAS' macro to verify node alias existence.

for example

#if DT_HAS_ALIAS(led_gpio)
# define LED_GPIO 0x00
#endif

@rruuaanng
Copy link
Contributor Author

Good suggestion, I'll change.

Copy link
Contributor

@bjarki-andreasen bjarki-andreasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

decsny
decsny previously approved these changes Oct 28, 2024
@dkalowsk dkalowsk added this to the v4.0.0 milestone Oct 28, 2024
Copy link
Contributor

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkalowsk not sure this qualifies as a bug fix for 4.0? :) To put it differently, I think some reviewers (speaking for myself at least) are expecting to be able to spend less time reviewing new features (albeit small-ish in this case) over the next couple weeks to focus on docs, bug fixes etc. and there is a good chance that these last minute additions will not get as many eyeballs on them as they typically would.

@rruuaanng
Copy link
Contributor Author

If there are no other issues, after merging this PR, I will modify the rst tag in the documentation regarding device tree errors.

tejlmand
tejlmand previously approved these changes Oct 29, 2024
@dkalowsk
Copy link
Contributor

dkalowsk commented Nov 4, 2024

@dkalowsk not sure this qualifies as a bug fix for 4.0? :) To put it differently, I think some reviewers (speaking for myself at least) are expecting to be able to spend less time reviewing new features (albeit small-ish in this case) over the next couple weeks to focus on docs, bug fixes etc. and there is a good chance that these last minute additions will not get as many eyeballs on them as they typically would.

@kartben normally I'd agree. This looks like the addition of a shortcut for a common DT macro mess. That said, it wasn't merged by the time RC2 was cut and thus it now needs an issue attached to it for merging, so moving this to 4.1.

Add 'DT_HAS_ALIAS' macro to verify node alias existence.

Signed-off-by: James Roy <[email protected]>
@nashif nashif merged commit 28238d0 into zephyrproject-rtos:main Nov 16, 2024
23 checks passed
@rruuaanng rruuaanng deleted the gh24495 branch November 17, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants