Skip to content

Conversation

@hongquan-prog
Copy link
Contributor

@hongquan-prog hongquan-prog commented Oct 29, 2024

If the serial port receives data after calling modem_iface_uart_init and before calling modem_context_register, the modem_iface_uart_isr function will not read the data in the serial port fifo register as the context has not been registered at this time, which will result in the program not being able to exit the interrupt. So I moved modem_context_register to before modem_iface_uart_init.

Fixes #80506

@github-actions
Copy link

Hello @hongquan-prog, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@hongquan-prog hongquan-prog changed the title drivers: wifi: esp_at: Fix serial receive interrupt not exiting during initialisation drivers: wifi: esp_at: Fix serial receive interrupt can't exiting Oct 29, 2024
@hongquan-prog hongquan-prog changed the title drivers: wifi: esp_at: Fix serial receive interrupt can't exiting drivers: wifi: esp_at: Fix serial receive interrupt can't exit Oct 29, 2024
@jukkar jukkar assigned mniestroj and unassigned jukkar Oct 29, 2024
@jukkar
Copy link
Member

jukkar commented Oct 31, 2024

@hongquan-prog could you rebase against latest upstream and force push a new version, there seems to be unrelated CI failures

@hongquan-prog
Copy link
Contributor Author

hongquan-prog commented Oct 31, 2024

@hongquan-prog could you rebase against latest upstream and force push a new version, there seems to be unrelated CI failures

👌 Thanks for your help.

@hongquan-prog hongquan-prog force-pushed the main branch 2 times, most recently from dcadf07 to 5d3bb74 Compare November 3, 2024 06:15
If a character is received immediately after modem_iface_uart_init called,
the modem_iface_uart_isr function will not read the data in the serial port
fifo register as the context has not been registered at this time,
which will result in the program not being able to exit the interrupt,
so the context should registered before the serial port is initialised.

Signed-off-by: Hongquan Li <[email protected]>
Copy link
Member

@jukkar jukkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@henrikbrixandersen henrikbrixandersen merged commit 41e3357 into zephyrproject-rtos:main Nov 21, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

espat serial receive interrupt not exiting during initialisation

5 participants