-
Notifications
You must be signed in to change notification settings - Fork 8.3k
drivers: wifi: esp_at: Fix serial receive interrupt can't exit #80547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: wifi: esp_at: Fix serial receive interrupt can't exit #80547
Conversation
|
Hello @hongquan-prog, and thank you very much for your first pull request to the Zephyr project! |
|
@hongquan-prog could you rebase against latest upstream and force push a new version, there seems to be unrelated CI failures |
👌 Thanks for your help. |
dcadf07 to
5d3bb74
Compare
If a character is received immediately after modem_iface_uart_init called, the modem_iface_uart_isr function will not read the data in the serial port fifo register as the context has not been registered at this time, which will result in the program not being able to exit the interrupt, so the context should registered before the serial port is initialised. Signed-off-by: Hongquan Li <[email protected]>
jukkar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If the serial port receives data after calling modem_iface_uart_init and before calling modem_context_register, the modem_iface_uart_isr function will not read the data in the serial port fifo register as the context has not been registered at this time, which will result in the program not being able to exit the interrupt. So I moved modem_context_register to before modem_iface_uart_init.
Fixes #80506