tests: Bluetooth: Tester: Fix use of uninitialized cig_id for CAP #80552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CAP tests used u_group->cig->index but the u_group->cig may have been deleted when the stream is released, which meant that u_group->cig == NULL when e.g. unicast_stop_complete_cb was called and that could cause failing tests as the index would just be a uninitialized value. Signed-off-by: Emil Gydesen <[email protected]>
zephyrbot
added
area: Bluetooth Audio
area: Bluetooth Qualification
zephyrbot
requested review from
Casper-Bonde-Bose,
MariuszSkamra,
asbjornsabo,
fredrikdanebjer,
jhedberg,
jthm-ot,
larsgk,
niym-ot,
pin-zephyr and
sjanc
kruithofa
approved these changes
Oct 29, 2024
cvinayak
approved these changes
Oct 29, 2024
larsgk
approved these changes
Oct 29, 2024
sjanc
approved these changes
Oct 29, 2024
niym-ot
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CAP tests used u_group->cig->index but the u_group->cig may have been deleted when the stream is released, which meant that u_group->cig == NULL when e.g. unicast_stop_complete_cb was called and that could cause failing tests as the index would just be a uninitialized value.
fixes #80551