Skip to content

Conversation

@MaureenHelm
Copy link
Member

@MaureenHelm MaureenHelm commented Oct 29, 2024

Follow-up to #80115 using adxl345 instead of adxl362

Adds adxl345 streaming and trigger configurations to accelerometer
samples for profiling the performance impact of adding rtio support to
max32 spi and adxl345 accelerometer drivers.

Signed-off-by: Maureen Helm [email protected]

c: @vladislav-pejic @dimitrije-lilic

@MaureenHelm MaureenHelm force-pushed the adxl345-rtio-profiling branch 2 times, most recently from 4c5681a to ff47bee Compare November 1, 2024 18:59
@github-actions
Copy link

github-actions bot commented Jan 1, 2025

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@MaureenHelm
Copy link
Member Author

MaureenHelm commented May 12, 2025

Rebased onto #88393

Streaming configuration is working, but the trigger configuration is not (still debugging...)

Streaming and trigger configurations are both working. Thanks @ubieda for the trigger fix in commit dc564f0

@MaureenHelm MaureenHelm requested a review from ubieda May 12, 2025 22:30
@github-actions github-actions bot removed the Stale label May 13, 2025
ubieda
ubieda previously approved these changes May 14, 2025
ubieda and others added 2 commits May 16, 2025 08:01
In order to prevent not serving all events that would clear the
interrupt line. This patch also removes FIFO servicing through
fetch/get APIs, as this is only exposed through streaming mode.

Signed-off-by: Luis Ubieda <[email protected]>
Sets the adxl345 driver thread name for easier debugging.

Signed-off-by: Maureen Helm <[email protected]>
@MaureenHelm MaureenHelm force-pushed the adxl345-rtio-profiling branch from 5f29959 to f22933c Compare May 16, 2025 13:02
@MaureenHelm MaureenHelm marked this pull request as ready for review May 16, 2025 13:02
@github-actions github-actions bot added area: Samples Samples platform: ADI Analog Devices, Inc. area: Shields Shields (add-on boards) area: Sensors Sensors labels May 16, 2025
Comment on lines 98 to 99
<6 0 &gpio1 4 0>, /* IO5/CS2 */
<7 0 &gpio1 5 0>; /* IO6/CS3 */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy paste error? (IO5 / IO6 appear twice)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks.

Specifies which gpio pins are connected to the pmod spi header on the
apard32690 board. This will enable using the adxl345 accelerometer
interrupt when attaching the pmod_acl shield.

Signed-off-by: Maureen Helm <[email protected]>
Fixes the pmod_acl shield board to specify the default accelerometer
output data rate with a preprocessor macro that corresponds to an
encoded register field value, rather than an integer value in Hertz.

Signed-off-by: Maureen Helm <[email protected]>
Specifies which gpio pin on the pmod header is attached to the adxl345
accelerometer interrupt.

Signed-off-by: Maureen Helm <[email protected]>
Changes the accelerometer polling sample to include data with the FIFO
watermark trigger instead of dropping it.

Signed-off-by: Maureen Helm <[email protected]>
Adds adxl345 streaming and trigger configurations to accelerometer
samples for profiling the performance impact of adding rtio support to
max32 spi and adxl345 accelerometer drivers.

Signed-off-by: Maureen Helm <[email protected]>
Configures the accelerometer polling and trigger samples to disable the
uart console when the rtt console is enabled. Having both consoles
enabled simultaneously doesn't currently work on the apard32690 platform
and it's redundant anyway.

Signed-off-by: Maureen Helm <[email protected]>
@MaureenHelm MaureenHelm force-pushed the adxl345-rtio-profiling branch from f22933c to d83bf9a Compare May 16, 2025 16:19
@sonarqubecloud
Copy link

@kartben kartben merged commit 6fd0363 into zephyrproject-rtos:main May 20, 2025
27 checks passed
@MaureenHelm MaureenHelm deleted the adxl345-rtio-profiling branch May 20, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Samples Samples area: Sensors Sensors area: Shields Shields (add-on boards) platform: ADI Analog Devices, Inc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants