Skip to content

Updated settings_file.c: Modified mkdir_for_file function to skip dir… #80624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Gopalkrishnbiradar wants to merge 3 commits into from
Closed

Updated settings_file.c: Modified mkdir_for_file function to skip dir… #80624

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2dabb14
fix: Skip mkdir for FatFS root in settings API
Gopalkrishnbiradar Oct 30, 2024
6ae3648
fix: UC2, clang-format, git action
Gopalkrishnbiradar Nov 6, 2024
6338a4f
Update settings_file.c
Gopalkrishnbiradar Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions subsys/settings/src/settings_file.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,18 +539,23 @@
if (i > 0 && file_path[i] == '/') {
dir_path[i] = '\0';

err = mkdir_if_not_exists(dir_path);
if (err) {
return err;
/* Skip mkdir for FatFS root directories (ending with ':') */
if (strrchr(dir_path, ':') == &dir_path[strlen(dir_path) - 1]) {
LOG_DBG("FatFS root directory detected, skipping mkdir for path: ""%s", dir_path);

Check warning on line 544 in subsys/settings/src/settings_file.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

LONG_LINE 

subsys/settings/src/settings_file.c:544  line length of 114 exceeds 100 columns

Check warning on line 544 in subsys/settings/src/settings_file.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

STRING_FRAGMENTS 

subsys/settings/src/settings_file.c:544  Consecutive strings are generally better as a single string
} else {
err = mkdir_if_not_exists(dir_path);
if (err) {
return err;
}
}
}

dir_path[i] = file_path[i];
}

return 0;
}


int settings_backend_init(void)
{
static struct settings_file config_init_settings_file = {
Expand Down
Loading