Skip to content

[Backport v3.6-branch] stream_flash: stream_flash_erase_page does not check whether requested offset is in range of stream flash owned area #80637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2024
Merged

[Backport v3.6-branch] stream_flash: stream_flash_erase_page does not check whether requested offset is in range of stream flash owned area #80637

merged 1 commit into from
Nov 6, 2024

Conversation

@de-nordic
Copy link
Contributor

@de-nordic de-nordic commented Oct 30, 2024 •
edited
Loading

Fixes #79800
failed backport: #80461

@de-nordic
storage/stream_flash: Fix range check in stream_flash_erase_page
72aea10 
Added check where stream_flash_erase_page checks if requested
offset is actually within stream flash designated area.

Fixes #79800

Signed-off-by: Dominik Ermel <[email protected]>
(cherry picked from commit 8714c17)
@zephyrbot zephyrbot added the area: Storage Storage subsystem label Oct 30, 2024
@de-nordic de-nordic self-assigned this Oct 30, 2024
@aescolar aescolar added this to the v3.7.1 milestone Oct 30, 2024
aescolar
aescolar previously approved these changes Oct 30, 2024
View reviewed changes
@aescolar aescolar assigned nashif and unassigned de-nordic Oct 30, 2024
@de-nordic
Copy link
Contributor Author

de-nordic commented Oct 30, 2024

@aescolar If this gets target at 3.7.1, is the #80462 even needed?

@aescolar aescolar modified the milestones: v3.7.1, v3.6.1 Oct 30, 2024
@aescolar
Copy link
Member

aescolar commented Oct 30, 2024

@aescolar If this gets target at 3.7.1, is the #80462 even needed?

Sorry :), That was just me being clumsy

@aescolar aescolar changed the title Backport 79830 to v3.6 branch [Backport v3.6-branch] Backport 79830 to v3.6 branch Oct 30, 2024
@henrikbrixandersen henrikbrixandersen added the Backport Backport PR and backport failure issues label Nov 4, 2024
@henrikbrixandersen
Copy link
Member

henrikbrixandersen commented Nov 4, 2024

@de-nordic Please look into the CI failures.

@de-nordic
Copy link
Contributor Author

de-nordic commented Nov 4, 2024

@de-nordic Please look into the CI failures.

Sorry I am fighting with build env to run that.

@de-nordic
Copy link
Contributor Author

de-nordic commented Nov 4, 2024

@henrikbrixandersen I need advice here: The added test is using feature that is not available in this release, it has been added later, which is possibility for device to not implement erase. What should I do now? Modify the test or drop it from backport?

@henrikbrixandersen
Copy link
Member

henrikbrixandersen commented Nov 4, 2024

@henrikbrixandersen I need advice here: The added test is using feature that is not available in this release, it has been added later, which is possibility for device to not implement erase. What should I do now? Modify the test or drop it from backport?

I would drop the test from the backport.

@de-nordic de-nordic dismissed stale reviews from henrikbrixandersen and aescolar via 72aea10 November 4, 2024 20:24
@de-nordic de-nordic force-pushed the backport-79830-to-v3.6-branch branch from a7c83cf to 72aea10 Compare November 4, 2024 20:24
@de-nordic
Copy link
Contributor Author

de-nordic commented Nov 4, 2024

@henrikbrixandersen I need advice here: The added test is using feature that is not available in this release, it has been added later, which is possibility for device to not implement erase. What should I do now? Modify the test or drop it from backport?

I would drop the test from the backport.

Thanks!

@nashif
Copy link
Member

nashif commented Nov 4, 2024

please change the PR title and do not include PR numbers in there

@de-nordic de-nordic changed the title [Backport v3.6-branch] Backport 79830 to v3.6 branch [Backport v3.6-branch] stream_flash: stream_flash_erase_page does not check whether requested offset is in range of stream flash owned area Nov 5, 2024
@de-nordic
Copy link
Contributor Author

de-nordic commented Nov 5, 2024

please change the PR title and do not include PR numbers in there

OK, fine, sorry. The PR naming for backports is not described anywhere.

@henrikbrixandersen henrikbrixandersen merged commit 03bc6e0 into v3.6-branch Nov 6, 2024
20 checks passed
@henrikbrixandersen henrikbrixandersen deleted the backport-79830-to-v3.6-branch branch November 6, 2024 05:44
@de-nordic de-nordic linked an issue Dec 10, 2024 that may be closed by this pull request
[Backport v3.6-branch] Failed to backport #79830 #80461
Closed
@de-nordic de-nordic mentioned this pull request Dec 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@MaureenHelm MaureenHelm MaureenHelm approved these changes

@aescolar aescolar aescolar approved these changes

Assignees

@henrikbrixandersen henrikbrixandersen

@MaureenHelm MaureenHelm

Labels

area: Storage Storage subsystem Backport Backport PR and backport failure issues

Projects

Backports
Status: Done

Milestone

v3.6.1

Development

Successfully merging this pull request may close these issues.

[Backport v3.6-branch] Failed to backport #79830

7 participants

@de-nordic @aescolar @henrikbrixandersen @nashif @MaureenHelm @zephyrbot