Skip to content

Fix: GPIO Stepper Driver #80646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nashif merged 6 commits into from
Nov 19, 2024
Merged

Fix: GPIO Stepper Driver #80646

nashif merged 6 commits into from
Nov 19, 2024

Conversation

@jilaypandya
Copy link
Member

@jilaypandya jilaypandya commented Oct 30, 2024 •
edited
Loading

  • Singularize instantiation of gpio-stepper driver
  • Add missing SPDX headers
  • Document set_event_callback function in steppers.rst
  • Use the correct dtcompatible in release notes
  • Rename tests from stepper_api to gpio_steppers
  • Add collaborators in stepper drivers

@zephyrbot zephyrbot added area: Stepper area: Process Release Notes To be mentioned in the release notes labels Oct 30, 2024
@jilaypandya jilaypandya added this to the v4.0.0 milestone Oct 30, 2024
@jilaypandya jilaypandya requested a review from dipakgmx October 30, 2024 19:19
@jilaypandya jilaypandya force-pushed the feature/update-stepper-doc branch from 27a4a2d to b067e13 Compare October 30, 2024 19:22
kartben
kartben requested changes Oct 30, 2024
View reviewed changes
@jilaypandya jilaypandya force-pushed the feature/update-stepper-doc branch from b067e13 to ec7ecda Compare October 30, 2024 21:25
@jilaypandya jilaypandya changed the title Update Stepper Documentation Update GPIO Stepper Driver Oct 30, 2024
@zephyrbot zephyrbot requested review from decsny and galak October 30, 2024 21:26
@jilaypandya jilaypandya force-pushed the feature/update-stepper-doc branch from ec7ecda to edb870b Compare October 30, 2024 21:30
@jilaypandya jilaypandya marked this pull request as draft October 30, 2024 21:31
@jilaypandya jilaypandya force-pushed the feature/update-stepper-doc branch 2 times, most recently from 5fa717b to d1097a4 Compare October 30, 2024 21:33
@jilaypandya jilaypandya marked this pull request as ready for review October 31, 2024 05:53
@jilaypandya jilaypandya requested a review from kartben October 31, 2024 05:53
@jilaypandya jilaypandya force-pushed the feature/update-stepper-doc branch 2 times, most recently from 7490f6c to 9a3e26f Compare October 31, 2024 14:54
@jilaypandya jilaypandya requested a review from faxe1008 October 31, 2024 14:54
faxe1008
faxe1008 reviewed Oct 31, 2024
View reviewed changes
faxe1008
faxe1008 reviewed Oct 31, 2024
View reviewed changes
dts/bindings/stepper/zephyr,gpio-stepper.yaml Outdated
Copy link
Contributor

@faxe1008 faxe1008 Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know if this is common practice for drivers generally or if it's fine that if more fields are added they simply go unused?

Copy link
Member Author

@jilaypandya jilaypandya Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right atleast in this case all the properties are used. hence have removed property_allowlist

@jilaypandya
drivers: stepper: fix stepper_set_event_callback c prototype and defi…
c4642da 
…nition

This commit fixes incorrect c prototype and defintion of
stepper_set_callback to stepper_set_event_callback

Signed-off-by: Jilay Pandya <[email protected]>
@jilaypandya
drivers: stepper: shell: fix null pointer check
025e52b 
This commit introduces null pointer check in print_callback

Signed-off-by: Jilay Pandya <[email protected]>
@jilaypandya
MAINTAINERS: Add collaborators in stepper drivers
3f59e13 
- bjarki-andreasen
- dipakgmx
- fabiobaltieri
- faxe1008

This commit adds dipakgmx as collaborator in stepper drivers

Signed-off-by: Jilay Pandya <[email protected]>
@jilaypandya
Copy link
Member Author

jilaypandya commented Nov 15, 2024 •
edited
Loading

release notes will need to be moved to 4.1, and migraiton guide entry added to indicate the rename of the compatible

Yep i have dropped the backport label and the release notes change. These fixes can come in with 4.1

@jilaypandya jilaypandya dismissed stale reviews from faxe1008, MaureenHelm, and dipakgmx via 3f59e13 November 15, 2024 19:38
@jilaypandya jilaypandya force-pushed the feature/update-stepper-doc branch from be77830 to 3f59e13 Compare November 15, 2024 19:38
@jilaypandya jilaypandya removed the Release Notes To be mentioned in the release notes label Nov 15, 2024
dipakgmx
dipakgmx previously approved these changes Nov 15, 2024
View reviewed changes
@kartben
Copy link
Contributor

kartben commented Nov 16, 2024

release notes will need to be moved to 4.1, and migraiton guide entry added to indicate the rename of the compatible

Yep i have dropped the backport label and the release notes change. These fixes can come in with 4.1

Migration guide entry is missing. Renaming the compatible means people will need to update their code

@jilaypandya
Copy link
Member Author

jilaypandya commented Nov 16, 2024

release notes will need to be moved to 4.1, and migraiton guide entry added to indicate the rename of the compatible

Yep i have dropped the backport label and the release notes change. These fixes can come in with 4.1

Migration guide entry is missing. Renaming the compatible means people will need to update their code

added

@jilaypandya
doc: migration-guide: 4.1: rename gpio-stepper compatible
164ed88 
add entry in migration guide 4.1 about renaming of compatible from
zephyr,gpio-steppers to zephyr,gpio-stepper

Signed-off-by: Jilay Pandya <[email protected]>
@jilaypandya jilaypandya force-pushed the feature/update-stepper-doc branch from 023fdea to 164ed88 Compare November 16, 2024 21:03
@zephyrbot zephyrbot added the Release Notes To be mentioned in the release notes label Nov 16, 2024
@nashif nashif merged commit 428db04 into zephyrproject-rtos:main Nov 19, 2024
23 checks passed
@jilaypandya jilaypandya deleted the feature/update-stepper-doc branch November 19, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kartben kartben kartben approved these changes

@MaureenHelm MaureenHelm MaureenHelm approved these changes

@dipakgmx dipakgmx dipakgmx approved these changes

@bjarki-andreasen bjarki-andreasen bjarki-andreasen approved these changes

@dkalowsk dkalowsk Awaiting requested review from dkalowsk

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@nashif nashif Awaiting requested review from nashif

@stephanosio stephanosio Awaiting requested review from stephanosio

@galak galak Awaiting requested review from galak

@fabiobaltieri fabiobaltieri Awaiting requested review from fabiobaltieri

@faxe1008 faxe1008 Awaiting requested review from faxe1008

Assignees

@MaureenHelm MaureenHelm

@jilaypandya jilaypandya

Labels

area: Devicetree area: Process area: Stepper bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug Release Notes To be mentioned in the release notes

Projects

None yet

Milestone

v4.1.0

Development

Successfully merging this pull request may close these issues.

Stepper API: stepper.h and stepper_shell.c