drivers: udc_nrf: handle overwritten Set Address commands #80666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set Address behavior is not specified when wValue is greater than 127, or if wIndex or wLength are non-zero. USB stack did check wValue and wLength but didn't care about wIndex value. Extend the check so non-zero wIndex also results in STALL response. Signed-off-by: Tomasz Moń <[email protected]>
tmon-nordic
force-pushed
the
nrf-usbd-set-address
branch
from
ea66b8d to
4d2d517
Compare
jfischer-no
reviewed
Nov 4, 2024
USBD peripheral automatically handles Set Address command which can lead to state mismatch between USB stack and the host. Keep track of device address and issue fake Set Address commands on mismatch. This fixes default vs addressed state mismatch that can occur due to sufficently high SETUP handling latency. The state mismatch was most commonly seen as SET CONFIGURATION failure when the enumeration happened during periods with increased latency. Signed-off-by: Tomasz Moń <[email protected]>
tmon-nordic
force-pushed
the
nrf-usbd-set-address
branch
from
4d2d517 to
309a5c6
Compare
jfischer-no
approved these changes
Nov 6, 2024
Contributor
|
@carlescufi and @tmon-nordic is this really needing to be in 4.0? it doesn't have enough approvals and RC3 is already done. I'd like move to 4.1.0 and pull it into a 4.0.1 backport if it is that needed. |
MarekPieta
approved these changes
Nov 19, 2024
Contributor
MarekPieta
left a comment
MarekPieta
left a comment
There was a problem hiding this comment.
Thank you for the fix. I confirmed locally that issues reported by me no longer replicate
carlescufi
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
USBD peripheral automatically handles Set Address command which can lead to state mismatch between USB stack and the host. Keep track of device address and issue fake Set Address commands on mismatch.
This fixes default vs addressed state mismatch that can occur due to sufficently high SETUP handling latency. The state mismatch was most commonly seen as SET CONFIGURATION failure when the enumeration happened during periods with increased latency.