Bluetooth: Audio: API for the distribute broadcast code procedure #80671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
Casper-Bonde-Bose,
MariuszSkamra,
Thalley,
asbjornsabo,
fredrikdanebjer,
jhedberg,
jthm-ot,
larsgk,
niym-ot,
pin-zephyr and
sjanc
Thalley
requested changes
Oct 31, 2024
Contributor
Thalley
left a comment
Thalley
left a comment
There was a problem hiding this comment.
A few minor things, otherwise LGTM
Define the API for the distribute broadcast code CAP procedure Signed-off-by: Andries Kruithof <[email protected]>
kruithofa
force-pushed
the
CAP_distribute_broadcastcode_API
branch
from
28fefde to
7ab1fe0
Compare
Thalley
approved these changes
Nov 5, 2024
Comment on lines
+1003
to
+1013
| /** | ||
| * @brief 16-octet broadcast code. | ||
| * | ||
| * If the value is a string or a the value is less than 16 octets, | ||
| * the remaining octets shall be 0. | ||
| * | ||
| * Example: | ||
| * The string "Broadcast Code" shall be | ||
| * [42 72 6F 61 64 63 61 73 74 20 43 6F 64 65 00 00] | ||
| */ | ||
| uint8_t broadcast_code[BT_ISO_BROADCAST_CODE_SIZE]; |
Contributor
There was a problem hiding this comment.
Out of scope of this PR, but perhaps we should consider defining a type for the broadcast code (similar to the UUID type in #77884), so that we don't have to write the explanation of how a broadcast code should be formatted all the places it is used, and can just add that to the type instead
Author
There was a problem hiding this comment.
Good idea, since this piece of code is in 3 files: iso.h, bap.h, and cap.h and the description is (more or less) copied to all places
larsgk
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define the API for the distribute broadcast code CAP procedure