bluetooth: host: Update FAE table type for HCI commands #80675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth
area: Bluetooth Host
zephyrbot
requested review from
Thalley,
alwa-nordic,
hermabe,
jhedberg,
rugeGerritsen,
sjanc and
theob-pro
rugeGerritsen
previously approved these changes
Oct 31, 2024
weeTike
approved these changes
Oct 31, 2024
jhedberg
requested changes
Oct 31, 2024
Member
jhedberg
left a comment
jhedberg
left a comment
There was a problem hiding this comment.
I think it would be good to quote the appropriate text from the spec, to explain why this change is correct. From Vol 6.0, Part B, section 2.4.2.52:
The ChFAE field contains the per-channel mode-0 FAE table of the local Controller. Every per-channel mode-0 FAE value is represented by an 8-bit signed integer
@adamfc2000 could you add that to the commit message? Thanks.
weeTike
suggested changes
Oct 31, 2024
Update FAE table type from array of uint8_t to int8_t. From Vol 6.0, Part B, section 2.4.2.52: "The ChFAE field contains the per-channel mode-0 FAE table of the local Controller. Every per-channel mode-0 FAE value is represented by an 8-bit signed integer" Signed-off-by: Adam Cavender <[email protected]>
adamfc2000
force-pushed
the
update_hci_fae_table_type
branch
from
f333cf1 to
ec483cd
Compare
weeTike
approved these changes
Oct 31, 2024
alwa-nordic
reviewed
Oct 31, 2024
Thalley
approved these changes
Oct 31, 2024
jhedberg
approved these changes
Oct 31, 2024
Member
|
Btw, if you want this for Zephyr 4.0, it'd make sense to create a matching bug report (something along the lines of "Bluetooth CS FAE table is incorrectly defined"). |
alwa-nordic
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update FAE table type from array of uint8_t to int8_t