-
Notifications
You must be signed in to change notification settings - Fork 8.4k
boards: thingy53: Fix missing GPIOs #80748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kartben
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Status and request GPIOs are not part of Edge connector, they use GPIO1.
Then they need to be part of some kind of abstraction, as that's how shields work (i.e you can't make assumptions of which board GPIOs are actually wired to a connector pin)
Also, https://docs.nordicsemi.com/bundle/ug_nrf7002_eb/page/UG/nrf7002_EB/pcb_edge_connector.html seems to indicate ST0 and REQ are indeed on pin 5 and 6 of the connector so I am not sure what this PR is supposed to fix?
|
Just a guess but it looks like if you're trying to fix issues with Thingy:53 then what's missing is basically making sure the edge_connector is completely defined (i.e add pin 5 and 6, possibly more) zephyr/boards/nordic/thingy53/thingy53_nrf5340_cpunet.dts Lines 75 to 81 in 5c376ad
|
Exactly, I just reinstated our previous downstream version, but I will check and extend the connections in edge_connector, thanks. |
f714fef to
c2d9b1e
Compare
|
@krish2718 you may want want to update the commit title, no? It isn't really |
Status and request GPIOs are missing from the edge connector, add those to fix Thingy53 + nRF7002EB build. Signed-off-by: Chaitanya Tata <[email protected]>
c2d9b1e to
ab36ab6
Compare
|
@krish2718 Can you please add an issue with details and link that issue to this PR. After RC2 only bug fixes with an associated Github issue will be merged into the upcoming 4.0 release. |
Thanks, updated the description with link to the issue. |
Status and request GPIOs are missing from the edge connector, add those
to fix Thingy53 + nRF7002EB build.
Fixes #80950