Skip to content

Conversation

@krish2718
Copy link
Contributor

@krish2718 krish2718 commented Nov 1, 2024

Status and request GPIOs are missing from the edge connector, add those
to fix Thingy53 + nRF7002EB build.

Fixes #80950

@zephyrbot zephyrbot added the area: Shields Shields (add-on boards) label Nov 1, 2024
Copy link
Contributor

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status and request GPIOs are not part of Edge connector, they use GPIO1.

Then they need to be part of some kind of abstraction, as that's how shields work (i.e you can't make assumptions of which board GPIOs are actually wired to a connector pin)

Also, https://docs.nordicsemi.com/bundle/ug_nrf7002_eb/page/UG/nrf7002_EB/pcb_edge_connector.html seems to indicate ST0 and REQ are indeed on pin 5 and 6 of the connector so I am not sure what this PR is supposed to fix?

@kartben
Copy link
Contributor

kartben commented Nov 1, 2024

Just a guess but it looks like if you're trying to fix issues with Thingy:53 then what's missing is basically making sure the edge_connector is completely defined (i.e add pin 5 and 6, possibly more)

gpio-map = <8 0 &gpio0 5 0>, /* P8, P0.05/AIN1 */
<9 0 &gpio0 4 0>, /* P9, P0.04/AIN0 */
<15 0 &gpio0 8 0>, /* P15, P0.08/TRACEDATA3 */
<16 0 &gpio0 9 0>, /* P16, P0.09/TRACEDATA2 */
<17 0 &gpio0 10 0>, /* P17, P0.10/TRACEDATA1 */
<18 0 &gpio0 11 0>, /* P18, P0.11/TRACEDATA0 */
<19 0 &gpio0 12 0>; /* P19, P0.12/TRACECLK */

@krish2718
Copy link
Contributor Author

Just a guess but it looks like if you're trying to fix issues with Thingy:53 then what's missing is basically making sure the edge_connector is completely defined (i.e add pin 5 and 6, possibly more)

gpio-map = <8 0 &gpio0 5 0>, /* P8, P0.05/AIN1 */
<9 0 &gpio0 4 0>, /* P9, P0.04/AIN0 */
<15 0 &gpio0 8 0>, /* P15, P0.08/TRACEDATA3 */
<16 0 &gpio0 9 0>, /* P16, P0.09/TRACEDATA2 */
<17 0 &gpio0 10 0>, /* P17, P0.10/TRACEDATA1 */
<18 0 &gpio0 11 0>, /* P18, P0.11/TRACEDATA0 */
<19 0 &gpio0 12 0>; /* P19, P0.12/TRACECLK */

Exactly, I just reinstated our previous downstream version, but I will check and extend the connections in edge_connector, thanks.

@kartben
Copy link
Contributor

kartben commented Nov 1, 2024

@krish2718 you may want want to update the commit title, no? It isn't really boards: shields: nrf7002eb: ... anymore

Status and request GPIOs are missing from the edge connector, add those
to fix Thingy53 + nRF7002EB build.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718 krish2718 changed the title boards: shields: nrf7002eb: Fix GPIOs boards: thingy53: Fix missing GPIOs Nov 1, 2024
@krish2718 krish2718 added this to the v4.0.0 milestone Nov 1, 2024
@mmahadevan108
Copy link
Contributor

@krish2718 Can you please add an issue with details and link that issue to this PR. After RC2 only bug fixes with an associated Github issue will be merged into the upcoming 4.0 release.

@krish2718
Copy link
Contributor Author

@krish2718 Can you please add an issue with details and link that issue to this PR. After RC2 only bug fixes with an associated Github issue will be merged into the upcoming 4.0 release.

Thanks, updated the description with link to the issue.

@mmahadevan108 mmahadevan108 added the bug The issue is a bug, or the PR is fixing a bug label Nov 5, 2024
@dkalowsk dkalowsk merged commit 5106a04 into zephyrproject-rtos:main Nov 6, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Shields Shields (add-on boards) bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wifi: sr_coex: Build failure due to missing GPIOs

6 participants