Skip to content

Conversation

@XenuIsWatching
Copy link
Member

const is ignored on the function return type. A warning is reported with -Wignored-qualifers. Remove the ignored qualifier.

In file included from zephyr/subsys/shell/modules/kernel_service.c:27:
zephyr/include/zephyr/debug/symtab.h:49:1: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   49 | const struct symtab_info *const symtab_get(void);
      | ^~~~~
zephyr/include/zephyr/debug/symtab.h:60:1: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   60 | const char *const symtab_find_symbol_name(uintptr_t addr, uint32_t *offset);
      | ^~~~~

@XenuIsWatching XenuIsWatching added this to the v4.0.0 milestone Nov 2, 2024
Copy link
Member

@ycsin ycsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted by @dcpleung, updating the function return type should fix the compilation warnings, could you update the patch please?

const is ignored on the function return type. A warning is reported with
-Wignored-qualifers. Remove the ignored const.

Signed-off-by: Ryan McClelland <[email protected]>
Copy link
Member

@ycsin ycsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ycsin ycsin self-assigned this Nov 5, 2024
@dkalowsk dkalowsk merged commit 952daca into zephyrproject-rtos:main Nov 6, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants