Skip to content

build: wifi: allow espressif boards to test net/wifi use cases #80785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 18, 2024
Merged

build: wifi: allow espressif boards to test net/wifi use cases #80785

merged 3 commits into from
Dec 18, 2024

Conversation

@sylvioalves
Copy link
Contributor

@sylvioalves sylvioalves commented Nov 3, 2024 •
edited
Loading

This aims to allow Espressif boards to test Wi-Fi drivers without binary blobs. The following changes were added:

  1. Convert NRF_WIFI_BUILD_ONLY_MODE and NXP_WIFI_BUILD_ONLY_MODE to use the same common Kconfig name BUILD_ONLY_NO_BLOBS.
  2. Modify hal_nxp and hal_espressif to support the above change. Include espressif Wi-Fi RF stubs.
  3. Modify all esp32-based boards.yml to allow net tests.

@sylvioalves sylvioalves force-pushed the enh/make_wifi_build_only_global branch from 264b271 to e00ed56 Compare November 3, 2024 00:16
@zephyrbot
Copy link

zephyrbot commented Nov 3, 2024 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@d2e2514 zephyrproject-rtos/hal_nxp@0ac8302 (master) zephyrproject-rtos/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_espressif manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Nov 3, 2024
@sylvioalves sylvioalves force-pushed the enh/make_wifi_build_only_global branch 3 times, most recently from 42bd0e8 to 95b4643 Compare November 3, 2024 00:33
@sylvioalves
Copy link
Contributor Author

sylvioalves commented Nov 3, 2024 •
edited
Loading

@krish2718 @dleach02 As you can see in this PR (commit bd260a9), I have aimed to consolidate the WIFI_BUILD_ONLY_MODE as common Kconfig. I have also submitted a similar approach to BT driver as you can see in #80786.

Please, let me know your thoughts about both. I think that we could rename XXX_BUILD_ONLY_MODE to something more clear as such as XXX_BUILD_WITH_NO_BLOBS or similar.

  1. Are you OK making this WIFI symbol global as in this PR?
  2. Does it sound good renaming it?
  3. We could create a global symbol to be used for both Wi-Fi and BT instead of splitting in 2. Any thoughts? Could be something like CONFIG_BUILD_WITH_NO_BLOBS.

@carlescufi PTAL.

@sylvioalves sylvioalves marked this pull request as ready for review November 3, 2024 02:21
@sylvioalves sylvioalves mentioned this pull request Nov 3, 2024
Merged
@zephyrbot zephyrbot added area: Samples Samples area: Sockets Networking sockets platform: NXP Drivers NXP Semiconductors, drivers platform: ESP32 Espressif ESP32 labels Nov 3, 2024
@sylvioalves sylvioalves requested a review from wmrsouza December 9, 2024 15:44
@sylvioalves
Copy link
Contributor Author

sylvioalves commented Dec 9, 2024

@sylvioalves some rebasing is needed. I'd be happy to approve once the Kconfig option has been moved away from its current wifi-specific location.

I was expecting hal_nxp to be merged so that I could update this PR accordingly. Will do so.

This PR is tricky because we don't want to merge the NXP HAL until this one is fully ready to merge. There are a lot of NXP HAL PRs that need to be synchronized. The ESP hal PR has merged so I would update this PR with the SHA.

@jukkar seems to have one request yet on a kconfig change, has that been done?

We can wait another round of approval and sync up when you feel confortable merging hal_nxp PR. I do not see any additional request.

jhedberg
jhedberg previously approved these changes Dec 9, 2024
View reviewed changes
jukkar
jukkar previously approved these changes Dec 10, 2024
View reviewed changes
@sylvioalves
Copy link
Contributor Author

sylvioalves commented Dec 10, 2024

@dleach02 I've rebased hal_nxp PR. Will rebase this one and submit again once merged in there. Up to you now.

@sylvioalves
Copy link
Contributor Author

sylvioalves commented Dec 12, 2024

@dleach02, are you able to move on with this? Do you expect anything else from my side?

dleach02
dleach02 reviewed Dec 17, 2024
View reviewed changes
@dleach02
Copy link
Member

dleach02 commented Dec 17, 2024

@sylvioalves do you know what is causing the CI failures?

Because we have a lot of NXP HAL side PRs we don't merge them until the Zephyr side is completely ready to be merged. Otherwise we end up blocking things that are ready.

@sylvioalves sylvioalves dismissed stale reviews from jukkar and jhedberg via ba504a9 December 17, 2024 18:53
@sylvioalves sylvioalves force-pushed the enh/make_wifi_build_only_global branch from e59899c to ba504a9 Compare December 17, 2024 18:53
@zephyrbot zephyrbot added the area: HTTP HTTP client/server support label Dec 17, 2024
@dleach02
Copy link
Member

dleach02 commented Dec 17, 2024 •
edited
Loading

The rebase passes my internal tests. I've merged the NXP HAL side so please update the west.yml NXP SHA

@sylvioalves
drivers: wifi: make WIFI_BUILD_ONLY_MODE global symbol
0035dbb 
Convert vendor specific **_WIFI_BUILD_ONLY_MODE symbol as global
in order to provide common build flag to enable CI with no blobs.

Signed-off-by: Sylvio Alves <[email protected]>
@sylvioalves
samples: net: wifi: add esp32 platform
a95452c 
Allow espressif platform to be properly tested in CI.

Signed-off-by: Sylvio Alves <[email protected]>
@sylvioalves
boards: esp32-based: remove net from ignore list
9cac2de 
This lets esp32-based boards to be tested regarding
Wi-Fi changes.

Signed-off-by: Sylvio Alves <[email protected]>
@sylvioalves sylvioalves force-pushed the enh/make_wifi_build_only_global branch from ba504a9 to 9cac2de Compare December 18, 2024 02:59
@sylvioalves sylvioalves removed the DNM This PR should not be merged (Do Not Merge) label Dec 18, 2024
@sylvioalves
Copy link
Contributor Author

sylvioalves commented Dec 18, 2024

PR is ready now.

@dleach02 dleach02 self-assigned this Dec 18, 2024
@dleach02
Copy link
Member

dleach02 commented Dec 18, 2024

To help move this along, I added myself as an assignee. @jukkar had previously approved this but the west.yml changes to align with the module PRs merging dropped it.

@kartben kartben merged commit 44eece3 into zephyrproject-rtos:main Dec 18, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kartben kartben kartben approved these changes

@jhedberg jhedberg jhedberg approved these changes

@jukkar jukkar jukkar approved these changes

@dleach02 dleach02 dleach02 approved these changes

@wmrsouza wmrsouza wmrsouza approved these changes

@Kludentwo Kludentwo Awaiting requested review from Kludentwo

@LucasTambor LucasTambor Awaiting requested review from LucasTambor

@marekmatej marekmatej Awaiting requested review from marekmatej

@nashif nashif Awaiting requested review from nashif

@pdgendt pdgendt Awaiting requested review from pdgendt

@rlubos rlubos Awaiting requested review from rlubos

@sachinthegreen sachinthegreen Awaiting requested review from sachinthegreen

@ssharks ssharks Awaiting requested review from ssharks

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

@uLipe uLipe Awaiting requested review from uLipe

@krish2718 krish2718 Awaiting requested review from krish2718

Assignees

@jukkar jukkar

@dleach02 dleach02

Labels

area: HTTP HTTP client/server support area: Networking area: Samples Samples area: Sockets Networking sockets area: Wi-Fi Wi-Fi manifest manifest-hal_espressif manifest-hal_nxp platform: ESP32 Espressif ESP32 platform: nRF Nordic nRFx platform: NXP Drivers NXP Semiconductors, drivers Release Notes To be mentioned in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@sylvioalves @zephyrbot @krish2718 @jhedberg @dleach02 @kartben @jukkar @wmrsouza